Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Granite SettingsSidebar and SettingsPage #66

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Use Granite SettingsSidebar and SettingsPage #66

merged 3 commits into from
Oct 13, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 13, 2023 •
edited

Uses Granite's SettingsSidebar and SimpleSettingsPage instead of rolling our own. While here, fix up bluetooth sharing page

Screenshot from 2023-10-13 11 50 37
Screenshot from 2023-10-13 11 50 34

@danirabbit danirabbit marked this pull request as ready for review October 13, 2023 18:48
@danirabbit danirabbit requested a review from a team October 13, 2023 18:48
meisenzahl
meisenzahl approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@meisenzahl meisenzahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring 👍

@meisenzahl meisenzahl merged commit 91ea6c1 into master Oct 13, 2023
4 checks passed
@meisenzahl meisenzahl deleted the danirabbit/simplesettings branch October 13, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisenzahl meisenzahl meisenzahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @meisenzahl