Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputPanel: Use C_ instead of NC_ #267

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

ryonakano
Copy link
Contributor

NC_ is for adding context for const strings like this:

const string FOO = NC_("context", "Foo");

warning ("Do %s", _(FOO));

So we should use C_ instead, otherwise these strings won't shown as translated.

@jeremypw jeremypw merged commit 7927cce into main Feb 18, 2024
3 of 4 checks passed
@jeremypw jeremypw deleted the ryonakano/outputpanel-correct-gettext-method branch February 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants