Add SearchView #147
Add SearchView #147
Conversation
There was a problem hiding this comment.
We probably need to ellipsize this, but otherwise it is looking good. It would also be nice to get the bold text like in Applications Menu, but that can be a follow-up. Nice work so far!
(Demonstrated with https://github.com/elementary/switchboard-plug-about/tree/long-search-string-demo)
|
@cassidyjames oops. You think middle ellipsize is probably good for that? |
|
@danrabbit yeah probably. We end-ellipsize in Applications Menu but I think middle will help ensure the most precise bits are visible. |
There was a problem hiding this comment.
Another note: because the search entry gets disabled, you can get it into a weird state if you're in a search and then try to open a plug from a settings:// URL, i.e. from an indicator or the Applications Menu search—there's no way to get out of the search to see the open plug without clicking a result or hitting the back button.
Instead, we should make sure to close the search when opening a plug.
Edit: oops, ignore my playing with alignment here, I was testing some unrelated things locally 😅
Fixes #98
Fixes #139