Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingsPage: float header #284

Merged
merged 10 commits into from
Jan 28, 2024
Merged

SettingsPage: float header #284

merged 10 commits into from
Jan 28, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 26, 2024 •
edited

Makes settingspage headers float. This will make more sense when this header also holds window controls, but for now another intermediary step

Screenshot from 2024-01-26 08 46 50

@danirabbit danirabbit changed the title Danirabbit/settingspage floatingheader SettingsPage: float header Jan 26, 2024
@danirabbit danirabbit marked this pull request as ready for review January 27, 2024 18:21
@danirabbit danirabbit requested a review from a team January 27, 2024 18:21
jeremypw
jeremypw approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, compiles and runs. Bluetooth plug still works.

I trust visuals will be ironed out in future.

@jeremypw jeremypw merged commit f29c5a7 into main Jan 28, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/settingspage-floatingheader branch January 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @jeremypw