Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchView: title results with last item #288

Merged
merged 5 commits into from
Feb 1, 2024
Merged

SearchView: title results with last item #288

merged 5 commits into from
Feb 1, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 31, 2024 •
edited

  • Show the last path item as a title and make the path secondary text
  • Return results from this last path item instead of the whole path
  • Sort results with matching prefixes before results with matches anywhere

BEFORE

Screenshot from 2024-01-31 10 58 16

AFTER

Screenshot from 2024-01-31 11 08 00

@danirabbit danirabbit requested a review from a team January 31, 2024 19:09
jeremypw
jeremypw reviewed Feb 1, 2024
View reviewed changes
src/SearchView.vala Outdated Show resolved Hide resolved
jeremypw
jeremypw approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good. Nice improvement.

@jeremypw jeremypw merged commit f455c88 into main Feb 1, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/search-titles branch February 1, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @jeremypw