Fixes for ListView Design #143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these are probably bugs in Greenfield that should be addressed there. At least the background thing is fixed by elementary/stylesheet#844 |
|
You were right - the background style is indeed an issue in Greenfield and your change at elementary/stylesheet#844 does fix it. For the flat entry further adjustments are needed as proposed in this PR (see screenshots): Before
After
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some styling issues which arised on Odin. What I also like to fix is the background color of the list content - but I did not figure out how to do it (see black arrow in 2nd screenshot).
Before
After