Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Task Lists using calendar-order #192

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Conversation

marbetschar
Copy link
Member

This PR will eventually fix #169 by adding support for the calendar-order property. Because this property was added in a newer Evolution Data Server version than shipped with the Ubuntu 20.04 LTS base, using Flatpak is a must.

This way, we can package a newer version of the needed evolution-data-server and ship it within the Tasks app.

@marbetschar
Copy link
Member Author

marbetschar commented Feb 22, 2021

The necessary code is in place, but right now throws error: E.util_source_compare_for_sort' is not available in libedataserver-1.2 3.39.2. Use libedataserver-1.2 >= 3.40.

Therefore we need to wait for the EDS 3.40 release and adjust the io.elementary.tasks.yml accordingly.

@Marukesu
Copy link
Contributor

Therefore we need to wait for the EDS 3.40 release and adjust the io.elementary.tasks.yml accordingly.

A problem can be the DBus interfaces, we need them in the same version of the host, since we use the online accounts plug to login.

@marbetschar
Copy link
Member Author

marbetschar commented Mar 30, 2021

@Marukesu I merged EDS v3.40 and E.util_source_compare_for_sort gets executed in MainWindow.vala:323. But it does not seem to have any effect.

How can I verify if this is related to the locally installed EDS version (not the one in the Flatpak) not populating the calendar-order field?

Nevermind. Obviously I can just print the field 🤣

@marbetschar
Copy link
Member Author

Alright; the E.SourceSelectable.order field is always 0 - so the new EDS function E.util_source_compare_for_sort uses the display_name for sorting.

Therefore this PR is ready to be merged. However, if we really want to make use of the new calendar-order property, the non-Flatpak version of EDS needs to be updated.

@marbetschar marbetschar marked this pull request as ready for review March 30, 2021 06:58
@marbetschar marbetschar added this to To do in Needs system EDS >= 3.40 via automation Apr 1, 2021
@marbetschar marbetschar moved this from To do to In progress in Needs system EDS >= 3.40 Apr 1, 2021
@marbetschar marbetschar removed this from In progress in Needs system EDS >= 3.40 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort order of Task Lists
3 participants