Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danrabbit/custom colors #552

Closed
wants to merge 20 commits into from
Closed

Danrabbit/custom colors #552

wants to merge 20 commits into from

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Dec 11, 2020

Todos:

  • convert themes to a hashtable and get rid of the theme struct. This will make lookups simpler
  • Persist the custom theme values in gsettings
  • Avoid a lot of extra work combining and splitting strings
  • Save theme name in gsettings so we're not relying on looking up the palette and trying to make a match
  • Recalculate contrast only when background and foreground values change

@sebastianlay sebastianlay mentioned this pull request Feb 16, 2021
4 tasks
@jeremypw
Copy link
Collaborator

@danrabbit Is this something you would like to push ahead with? If so it would make other PRs like #633 redundant.

@jeremypw
Copy link
Collaborator

This would probably also affect PRs #546 and #630.

@danirabbit
Copy link
Member Author

Yeah if someone else wants to pick this up, feel free! I just haven't been able to revisit it for a while.

Since this is a pretty big branch, it probably makes sense to try to break it up into smaller cleanups that can be merged before adding full color scheme support

# Conflicts fixed in:
#	src/MainWindow.vala
This was referenced Jun 28, 2022
@jeremypw
Copy link
Collaborator

jeremypw commented Jul 6, 2022

@danrabbit Can this PR be closed now?

@danirabbit
Copy link
Member Author

Yes definitely

@danirabbit danirabbit closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants