Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts Ctrl + PageUp and Ctrl + PageDown to switch between tabs #700

Merged

Conversation

Faelian
Copy link
Contributor

@Faelian Faelian commented Feb 4, 2023

Control + PageUp and Control + PageDown are common shortcuts to switch between tabs.
There are used by other apps such as Web, Chrome and Firefox, and other terminals like gnome-terminal.

This commit add these shortcuts to io.elementary.terminal.

@Faelian Faelian changed the title Add shortcuts Crtl + PageUp and Ctrl + PageDown to switch between tabs Add shortcuts Ctrl + PageUp and Ctrl + PageDown to switch between tabs Feb 4, 2023
@lenemter lenemter requested a review from a team February 5, 2023 03:57
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Shouldn't be any problem merging this as other common apps already use this shortcut for a similar purpose.

@jeremypw jeremypw merged commit 7f41498 into elementary:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants