Update Meson Files #701
Merged
Update Meson Files #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declare meson targets in the files in they respective folders and make the main meson file handle only dependencies, version checking and compiler arguments. also set meson minimal version to 0.58 and stop using deprecated functions.
Marukesu
force-pushed
the
maru/update-meson
branch
from
65edd77
to
e4aeb41
Compare
danirabbit
reviewed
Feb 9, 2023
There was a problem hiding this comment.
This mostly looks good, just a few inline comments. I think generally some of these lines are a bit harder to read compared to how they were before. Having arguments separated onto different lines for some of these methods that take a bunch of arguments makes it just easier to read at a glance what's happening
meson.build
Outdated
Comment on lines
13
to
17
| glib_version = '>=2.40' | ||
| gtk_version = '>-3.24' | ||
| granite_version = '>=6.1' | ||
| handy_version = '>=0.83' | ||
| vte_version = '>=0.59' |
There was a problem hiding this comment.
Is there a good reason to have these all separated out like this? it seems like it kind of just makes it more complicated and I'm not sure we ever want to re-use these values besides glib_version
There was a problem hiding this comment.
i would say it make more easy to find minimal versions of dependencies, but i can inline the not re-used ones if preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare meson targets in the files in they respective folders and make the main meson file handle only dependencies, version checking, and compiler arguments. Also set meson minimal version to 0.58 and stop using deprecated functions.