fix(Themes): increase contrast for gray, fixes #682 #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #682, the gray color doesn't have sufficient contrast against the background in dark theme. This PR replaces it with a more reasonable variant.
a picture is worth a thousand words
Before:
![image](https://private-user-images.githubusercontent.com/1671665/298389377-1e43d14c-8743-4e7b-904c-0db1b48b10cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0NTgxNDMsIm5iZiI6MTcyMTQ1Nzg0MywicGF0aCI6Ii8xNjcxNjY1LzI5ODM4OTM3Ny0xZTQzZDE0Yy04NzQzLTRlN2ItOTA0Yy0wZGIxYjQ4YjEwY2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjBUMDY0NDAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjQ3NmFkYzAzOWIyMDRhMTIzMjFmNDMyNGUwNDhmZWZkZjlhNzRhZTIyMGQxODQ1Y2I0YWE2ZTUzZjc3ZTAyMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.vCZjcCW-DFjXzrCFzT0NeQEDynhF33xjhADY1Z8Wh1U)
After:
![image](https://private-user-images.githubusercontent.com/1671665/298389392-5132d1d3-5f1e-45c7-8cc9-bbcbf1e34fd8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0NTgxNDMsIm5iZiI6MTcyMTQ1Nzg0MywicGF0aCI6Ii8xNjcxNjY1LzI5ODM4OTM5Mi01MTMyZDFkMy01ZjFlLTQ1YzctOGNjOS1iYmNiZjFlMzRmZDgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjBUMDY0NDAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTg4NTYwMWFkNTgxNTMyNWYyYTkzNjEyZWIyZGUyYWQxODIxMGI0YjI3NjU4MTIyZmViYzMwYjcyMGM2NDdlYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0CD5Lu2V9vkT49mNt89hsX1aT5JpMRGiEPgRQKfvb-M)