Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects.Video: remove unused properties, signals, functions #322

Merged
merged 4 commits into from
Jan 15, 2023

Conversation

danirabbit
Copy link
Member

Review with "hide whitespace changes". Removes unused signals, properties, single-use/line functions, etc. Scope down access on properties where possible

@danirabbit danirabbit requested a review from a team December 14, 2022 17:20
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess thumbnail_normal_path variable can be removed? It is not used anywhere now.

@zeebok
Copy link
Contributor

zeebok commented Jan 15, 2023

I guess thumbnail_normal_path variable can be removed? It is not used anywhere now.

It is still used in the if statement, it was all moved

@zeebok zeebok merged commit 31cc84a into master Jan 15, 2023
@zeebok zeebok deleted the videoobject-cleanup branch January 15, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants