Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlist: Preparations for GTK4 #337

Merged
merged 4 commits into from Jul 7, 2023
Merged

Playlist: Preparations for GTK4 #337

merged 4 commits into from Jul 7, 2023

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jul 7, 2023 •
edited

  • Merge the Playlist class into PlaylistPopover as it derives from Gtk.ListBox which is final in GTK4
  • Update some margins etc.
  • Use a separate Gee.ArrayList instead of ListBox.get_children for playlist management as get_children isn't available in GTK4
  • This also fixes an issue causing the items in the playlist to not show up in the popover

@leolost2605 leolost2605 requested a review from a team July 7, 2023 14:32
@danirabbit danirabbit merged commit 3f7bdbe into master Jul 7, 2023
3 checks passed
@danirabbit danirabbit deleted the playlist-prep-gtk4 branch July 7, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leolost2605 @danirabbit