Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BottomBar and PlayerPage: GTK4 preparations #343

Merged
merged 2 commits into from Jul 9, 2023
Merged

BottomBar and PlayerPage: GTK4 preparations #343

merged 2 commits into from Jul 9, 2023

Conversation

leolost2605
Copy link
Member

  • Derive BottomBar from Gtk.EventBox (to be replaced with controllers and a normal box in gtk4) as Gtk.Revealer is final in GTK4
  • Do the revealing in PlayerPage and update some eventhandlers there

@leolost2605 leolost2605 requested a review from a team July 8, 2023 19:29
danirabbit
danirabbit approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danirabbit danirabbit enabled auto-merge (squash) July 9, 2023 18:17
@danirabbit danirabbit merged commit 00ca561 into master Jul 9, 2023
3 checks passed
@danirabbit danirabbit deleted the bottombar-gtk4-prep branch July 9, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leolost2605 @danirabbit