Drop support for optical media #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think for someone who just wants to watch a DVD on an old pc it would be quite useful to not have to get a third party app but just have it working out of the box even though support in videos isn't perfect. |
|
I think one of the issues in the past was it's illegal to actually ship the DVD decoder. Not sure if that's changed, but something to consider 😅 |
|
I am 👍 on this as the AppCenter includes apps such "MakeMKV" that can transcode DVDs into file formats playable by freely. |
zeebok
previously approved these changes
Jun 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173
Closes #170
Closes #131
Closes #81
Closes #80
Closes #16
Closes #15
Closes #9
There are a ton of old reports about Optical Media support but afaict the top selling computers in 2023 don't even have optical media drives anymore. I don't personally own any computers with optical media drives or any optical media so I have no way to test or fix any of these issues. Unless there's someone who is like really passionate about optical media and wants to work on it, I feel like we should remove this