Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Lamp post on dock'. #99

Closed
wants to merge 1 commit into from
Closed

Add 'Lamp post on dock'. #99

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2020

  • I've read and followed the general guidelines
    • Looks good in Pantheon on elementary OS
    • Not too distracting if a non-maximized window is open
    • No text or logos
    • No people
    • At least 3200×1800 px
  • I've updated debian/copyright with:
    • The name of the wallpaper and/or its original author
    • A link to where it can be downloaded
    • Included under the respective license section (or created a new one if appropriate)
  • I've added the artist metadata using exiftool

Why it should be included:

It looks nice, with a slightly darker tone.

Screenshot(s) of it in Pantheon on elementary OS:

I couldn't do this I'm afraid as I'm not (yet) an Elementary OS user. I tried GIMPing it onto the examples in the README, but it looked yuk when I tried to remove the background from them...

@ghost
Copy link
Author

ghost commented Apr 14, 2020

I couldn't find a debian/copyright file, so couldn't do that bit I'm sorry. The image is from here though: https://unsplash.com/photos/0HFkStS9Gq0

@ghost
Copy link
Author

ghost commented Apr 14, 2020

Lamp post on dock

@cassidyjames
Copy link
Contributor

cassidyjames commented Apr 14, 2020

Thanks for the PR!

Ah, yeah we need to update the instructions for copyright info (or auto-build that file in CI or something). It's in a different branch, but that requires another PR to update.

Here's a screenshot on elementary OS:

Screenshot from 2020-04-14 14-15-10@2x

Personally, I'm 👎 on this one… I like the photo itself alright, but it feels like being non-centered is super obvious with the dock there.

@ghost
Copy link
Author

ghost commented Apr 15, 2020

@cassidyjames Hmm, good point... Would it be worth cropping the image somewhat then? Something like this:

cropped-dock
(I GIMPed the dark README example, that seemed easier than the light one)

If so, I'll update the PR.

As for the copyright file, I've created an issue for that here: #100

@danirabbit
Copy link
Member

Hm yeah it's a bit similar to Sunset by the pier as well. I think if we were to include this one, it would have to replace the other one

@ghost
Copy link
Author

ghost commented Apr 17, 2020

Based on the comments above (which make valid points), I'm going to close this PR (not centred and too similar to existing image).

@ghost ghost closed this Apr 17, 2020
@cassidyjames cassidyjames added the Transparent + Light Fg Makes the panel go transparent with light-colored text and icons label Apr 17, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Transparent + Light Fg Makes the panel go transparent with light-colored text and icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants