Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance problem #235

Open
Dirli opened this issue Oct 8, 2020 · 2 comments
Open

Performance problem #235

Dirli opened this issue Oct 8, 2020 · 2 comments
Labels
Status: Confirmed Verified by someone other than the reporter

Comments

@Dirli
Copy link

Dirli commented Oct 8, 2020

after adding PR (#232), I noticed a few bugs

  1. when scrolling through months, if you go far enough (for example, in 1999), you notice increased memory consumption

screen1

this is because the array of months is not cleared. after closing the widget, everything remains in memory.

  1. when switching to a new month, a lot of unnecessary actions are performed.

screen2

The calendar model changes 4 times (per iteration), each time it completely redraws everything related to events.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@fs3o5
Copy link
Member

fs3o5 commented Oct 12, 2020

  1. Are you sure this issue is related to this PR? The calendar data is still stored in the same way. The calendar data should probably still be cleared after some time/when closing the widget.

  2. The months are changed so often because the next calendar page needs to be drawn before it is switched to. It might still be a good idea to change that.

@Dirli
Copy link
Author

Dirli commented Oct 12, 2020

1 carousel is a gtk.container, you fill it (when to switch new months for a long time), but you don't remove it from it. when closing, nothing is cleared on its own
2 it's not your problem, you're singleton's hostage, need to change the calendar_model. you can't use singleton anymore (it's better not to use it at all)

@fs3o5 fs3o5 self-assigned this Oct 22, 2020
@fs3o5 fs3o5 added the Status: Confirmed Verified by someone other than the reporter label Oct 22, 2020
@fs3o5 fs3o5 removed their assignment Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

No branches or pull requests

2 participants