Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues related to the use of Hdy.Carousel #244

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

fs3o5
Copy link
Member

@fs3o5 fs3o5 commented Nov 27, 2020

This PR addresses problems related to the use of libhandy for the calendar. #232

  • Properly update selected dates when switching months.
  • Rewrite CalendarModel in order to not perform unnecessary actions all the time Performance problem #235
  • Sometimes the Carousel scrolls to an empty page, but I can't reliably reproduce the issue.
  • Free the memory, when closing the indicator. Performance problem #235
    (I would appreciate help with the last one as I'm not able to get the memory freed. I try to free it in CalendarView.clear ().

@jeremypw
Copy link
Collaborator

@fs3o5 Probably best to submit separate PR for each problem if you are still interested in working on this. Otherwise open separate issue reports (where necessary) for each issue you were trying to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants