evolution optional dependency #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for your branch! I'm not certain if it makes sense to carry these changes since other parts of Pantheon use EDS as well. What is the value in adding a conditional compile for Evolution here? As it stands, there's no way to review or merge this branch. It has too many unrelated changes. A diff of +1,354 −1,205 is not realistic to review. If you'd like to propose several changes (like reorganizing files, etc), please use multiple branches |
|
You very quickly learned all the changes) unfortunately in smaller chunks long and more labor-intensive |
worldofpeace
added a commit
to worldofpeace/nixpkgs
that referenced
this pull request
Apr 22, 2020
These were rejected upstream, sadly elementary/wingpanel-indicator-datetime#207.
10 tasks
worldofpeace
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Apr 22, 2020
These were rejected upstream, sadly elementary/wingpanel-indicator-datetime#207. (cherry picked from commit 7a164bf)
stigok
pushed a commit
to stigok/nixpkgs
that referenced
this pull request
Jun 12, 2020
These were rejected upstream, sadly elementary/wingpanel-indicator-datetime#207. (cherry picked from commit 7a164bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really did not like that the evolution-data-server was a mandatory dependency, I tried to make it an optional dependency, for those who do not need it) I think it worked. Several issues were corrected along the way.
issue #206 fix too