#270: Add button for adding event #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue elementary#270, Add button for adding event.
benjaminkitt
force-pushed
the
270-button-adding-event
branch
from
5bc31fa
to
fbbde13
Compare
benjaminkitt
commented
Feb 1, 2022
| @@ -241,8 +249,11 @@ public class DateTime.Widgets.CalendarView : Gtk.Grid { | |||
| } | |||
|
|
|||
| // TODO: As far as maya supports it use the Dbus Activation feature to run the calendar-app. | |||
| public void show_date_in_maya (GLib.DateTime date) { | |||
| var command = "io.elementary.calendar --show-day %s".printf (date.format ("%F")); | |||
| private void open_maya_with_options (GLib.DateTime? day_to_show, bool add_event = false) { | |||
There was a problem hiding this comment.
Expanded the previous show_date_in_maya method to also allow for displaying the new event dialog. Public API remains the same and available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #270, Add button for adding event.
This PR is blocked by elementary/calendar#742, which addresses source calendars not loading prior to the display of the new event dialog when loading calendar using the
--add-eventflag.While a Dbus solution to this request is preferable (as noted in the pre-existing TODO), I felt that was beyond the scope of this PR as a Bitesize issue. I will explore a Dbus solution in a future PR. As it stands, this PR, along with the aforementioned PR on Calendar, does at least provide a good first step in providing the functionality.