Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide percentage in panel when indicator shows calculating #146

Merged
merged 4 commits into from Sep 21, 2020
Merged

Hide percentage in panel when indicator shows calculating #146

merged 4 commits into from Sep 21, 2020

Conversation

meisenzahl
Copy link
Member

Fixes #145

@meisenzahl
Copy link
Member Author

Logic is based on

wingpanel-indicator-power/src/Widgets/DeviceRow.vala

Lines 85 to 90 in fa355d1

var percent = (int)Math.round (battery.percentage);
var charging = battery.is_charging;
if (percent <= 0) {
return _("Calculating…");
}

@cassidyjames cassidyjames requested a review from a team September 20, 2020 20:02
jeremypw
jeremypw approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected - thanks!

@jeremypw jeremypw merged commit af6a3da into elementary:master Sep 21, 2020
@meisenzahl meisenzahl deleted the hide-percentage-in-panel-when-indicator-shows-calculating branch September 21, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Percentage in panel shows "0%" when indicator shows "calculating"
2 participants
@meisenzahl @jeremypw