Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide user settings in Demo Mode #172

Merged
merged 6 commits into from Jan 2, 2023
Merged

Conversation

meisenzahl
Copy link
Member

Closes #63

Before

After

@meisenzahl meisenzahl requested a review from a team December 30, 2022 08:51
@zeebok
Copy link

zeebok commented Jan 1, 2023

Is this still an issue with eOS7? I am fairly sure in the early access build that you create a user when you live boot so this wouldn't be needed anymore. But maybe that is changing for release? Hmm I guess that is a question for @danirabbit to answer. If this is something that will be an issue in the future this is definitely a good patch!

@meisenzahl
Copy link
Member Author

I tested this with a daily build ISO of OS 7. Screenshots are taken in Demo Mode.

src/Utils.vala Outdated Show resolved Hide resolved
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@danirabbit danirabbit merged commit 7f4dd59 into master Jan 2, 2023
@danirabbit danirabbit deleted the hide-user-settings-in-demo-mode branch January 2, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live session user doesn't show up in Juno Beta 2 live session
3 participants