Make action items into circle buttons #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danirabbit
commented
Feb 28, 2023
•
danirabbit
commented
- Make a lot of room here to start creating more of a quick settings menu
- Only show suspend button when it would do something different from "Lock"
Closed
|
Is there any worry that having no text would pose any issues for those with certain disabilities or impairments? I am not sure how things like screen readers work. If it is based on the tooltips then I guess it would still work as intended. In general I really like this, just want to be sure we don't take any large steps backwards with accessibility. |
zeebok
approved these changes
Mar 2, 2023
|
Yeah I think it would be the same as any other image buttons in headerbars etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.