This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Allow running without a display manager #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
XDG_SEAT_PATHonly exists if the DE has been launched via something that sets it (e.g. lightdm).With my experiment of logging in via VNC, I don't go via the display manager and instead launch a session directly on VNC login and hence don't have this env var set.
Passing a null path to
get_proxy_synccauses an assertion that crashes wingpanel. So while this doesn't change the behaviour at all for normal use, it makes it way less crashy for nonstandard display managers or weird remote logins like mine.