Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale: use more compact chunky sliders #246

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

danirabbit
Copy link
Member

Redesign the scale widget as a chunky slider. You can still click the icon to mute/unmute

BEFORE

Screenshot from 2023-02-14 12 46 45

AFTER

Screenshot from 2023-02-14 12 45 53

@danirabbit danirabbit requested a review from a team February 14, 2023 20:59
@jlnr
Copy link
Member

jlnr commented Feb 15, 2023

Is there a way to do this without reducing the contrast so much? One might look for these sliders in a hurry if something is too loud. (Black chunky sliders?)

@TomiOhl
Copy link
Contributor

TomiOhl commented Feb 20, 2023

Is there a way to do this without reducing the contrast so much? One might look for these sliders in a hurry if something is too loud. (Black chunky sliders?)

Or use the accent color? 🤔 For example Android uses the accent color for sliders. Although that's not the case in elementary so far, these are chunky sliders, not present anywhere else in the system yet, so that might not be an issue.

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with other comments that the coloring needs review. In particular there appears to be little difference at a glance between a slider that is at 100% and one that is muted.

@danirabbit danirabbit marked this pull request as draft June 12, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants