Fix wingpanel potentially overlapping windows #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
approved these changes
Feb 25, 2019
|
@codygarver Can we get a |
rycee
pushed a commit
to rycee/nixpkgs
that referenced
this pull request
Mar 7, 2019
worldofpeace
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Mar 7, 2019
elementary/wingpanel#198 (cherry picked from commit 3ba5f17)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
elementary/wingpanel#198 (cherry picked from commit 3ba5f17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #130
I noticed that sometimes my wingpanel would overlap left/right tiled windows. Looking into it it seemed like the allocated height of the panel changed from 24 (the requested height) to 30. For some people, in some cases this switch would happen after the slide in animation where the truts? are updated.
I filtered out all indicators and it seemed like these indicators caused the panel's height to go from 24 to 30:
You can also see that those 4 have a margin above and below:
I'm assuming we actually like the 30, so this PR makes sure we start of at 30.
For comparison:
24 height:
30 height: