Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default CSS for visited, focus & hover missing in Theme Styling for button color. #10733

Open
4 of 5 tasks
premanshup opened this issue Mar 4, 2020 · 0 comments
Open
4 of 5 tasks

Comments

@premanshup
Copy link

premanshup commented Mar 4, 2020

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

When no color is added from the Elementor theme style, Elementor by default loads this below CSS for buttons:

https://share.getcloudapp.com/d5u0PebR

.elementor-button:hover, .elementor-button:focus, .elementor-button:visited {
    color: #fff;
}

From Astra, we have provided support from customizer to add button color in which we override this CSS from our theme to be applied from the customizer.

https://share.getcloudapp.com/KouWleew

When the color is added from Elementor theme style, the CSS for visited, focus and hover is missing from the kit.

body.elementor-kit-1781 button, body.elementor-kit-1781 input[type="button"], body.elementor-kit-1781 input[type="submit"], body.elementor-kit-1781 .elementor-button {
    color: #F80606;
}

https://share.getcloudapp.com/GGuN2Aro

This produces an issue, where the text color works perfectly from elementor theme style but if the color is set from Astra customizer then the visited CSS comes from Astra and the elementor theme style CSS does not work anymore for the visited button.

Steps to reproduce

  1. Add a button Elementor.
  2. Install and activate latest Astra theme.
  3. Go to Dashboard - Elementor -> Settings -> Disable Default Colors ( check )
  4. Add color from Astra customizer -> Gobal -> Buttons -> https://share.getcloudapp.com/xQugY06Z
  5. Add color from Elementor Theme Style -> https://share.getcloudapp.com/6quBxLYe
  6. Check on front end - the button text color will appear properly ( red ) but when once clicked, the visited color changes to yellow which comes from the Astra Theme.

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a default WordPress theme active.
  • I can reproduce this bug consistently using the steps above.

Environment

System Info ```

== Server Environment ==
Operating System: WINNT
Software: Apache/2.4.39 (Win64) OpenSSL/1.1.1b PHP/7.3.4
MySQL version: mariadb.org binary distribution v5.6.42-84.2
PHP Version: 7.3.4
PHP Max Input Vars: 1000
PHP Max Post Size: 256M
GD Installed: Yes
ZIP Installed: Yes
Write Permissions: All right
Elementor Library: Connected

== WordPress Environment ==
Version: 5.3.2
Site URL: http://localhost/wordpress-5.3
Home URL: http://localhost/wordpress-5.3
WP Multisite: No
Max Upload Size: 256 MB
Memory limit: 512M
Permalink Structure: Plain
Language: en-US
Timezone: 0
Debug Mode: Active

== Theme ==
Name: Astra
Version: 2.3.2
Author: Brainstorm Force
Child Theme: No

== User ==
Role: administrator
WP Profile lang: en_US
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36

== Active Plugins ==
Astra Pro
Version: 2.3.3
Author: Brainstorm Force

Elementor
	Version: 2.9.3
	Author: Elementor.com

== Must-Use Plugins ==
astra-wp-cli.php
Version:
Author:

Health Check Troubleshooting Mode
	Version: 1.7.0
	Author: 

== Elements Usage ==

wp-page : 1
	button : 1

== Log ==

JS: showing 1 of 1JS: 2020-03-04 06:33:27 [error X 3][http://localhost/wordpress-5.3/wp-content/plugins/elementor/assets/js/editor.js?ver=2.9.2:14423:43] Cannot read property 'has_elements' of undefined

Log: showing 1 of 12020-03-04 06:34:45 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor',
'from' => '2.9.2',
'to' => '2.9.3',
)]

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant