Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font Awesome Pro SVG support #11772

Closed
2 tasks done
Pab89 opened this issue Jul 1, 2020 · 7 comments
Closed
2 tasks done

Add Font Awesome Pro SVG support #11772

Pab89 opened this issue Jul 1, 2020 · 7 comments
Labels
control/icons References any instance of the Icon control. status/merged Indicates when a Pull Request has been merged to a Release.
Milestone

Comments

@Pab89
Copy link

Pab89 commented Jul 1, 2020

Prerequisites

  • I have searched for similar features requests in both open and closed tickets and cannot find a duplicate.
  • The feature is still missing in the latest stable version of Elementor ( Elementor Pro. )

What problem is your feature request going to solve? Please describe.
Currently, elementor only supports the Web Fonts options I Font awesome 5 Kits. Per https://docs.elementor.com/article/585-icon-library . Please add support for the SVG options, it's more flexible and gives smaller file sizes, which will increase pagespeed.

Describe the solution you'd like
Make elementor compatible with Font Awesome 5 Pro SVG kit's instead of only Web Fonts.

@Pab89
Copy link
Author

Pab89 commented Jul 2, 2020

I did some more research, going from using web fonts to SVG saves 54 KB, which is a lot. The main problem is that the widgets use "fill" as the CSS attribute to change color if that switches to "color" instead, everything works. Currently, I have switched to SVG to save the 54 kilobytes, and manually write the CSS to change the color of all the icons I use, but that's a big hassle. I don't think it would be a big change to give the option to use "color" instead of "fill" for icons, which would solve the problem.

@jazir555
Copy link

As in my thread, could you automatically replace all icons with individual svgs instead of loading the whole font library? Lots of unnecessary icons downloaded if you download the whole font file. Only icons that are used should be loaded

@DorShahar
Copy link

Hi
We are about to release a new experiment that will convert Font Awesome icons to be used with SVG.
With that being said, if you are using FA Pro you can convert icons to be used as SVG by yourself:
In FA - go to Kit settings, and under Technology, change to SVG instead of Web Font:
image

The experiment will not convert FA Pro to be used as SVG, it will stay as Web Font only for the Pro icons.

Thanks

@jazir555
Copy link

@DorShahar

When are you releasing it?

@DorShahar
Copy link

In the next Core version (v3.4.0)

@DorShahar DorShahar added the status/merged Indicates when a Pull Request has been merged to a Release. label Jul 28, 2021
@DorShahar DorShahar added this to the 3.4.0 milestone Jul 28, 2021
@drawcard
Copy link
Contributor

Nice, will the SVG option become the new default eventually?

@Yahav
Copy link

Yahav commented Mar 20, 2022

@DorShahar ETA on this available yet? still having issues when using FA-Pro SVG icons, the icon color are changed to the global link color site-wide..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control/icons References any instance of the Icon control. status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Development

No branches or pull requests

6 participants