Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request - Add FontAwesome to Social Icons #1455

Closed
pingram3541 opened this issue Mar 13, 2017 · 4 comments
Closed

Enhancement Request - Add FontAwesome to Social Icons #1455

pingram3541 opened this issue Mar 13, 2017 · 4 comments

Comments

@pingram3541
Copy link
Contributor

It would be great to have a filter to enable font-awesome into the drop down so we can choose things like the envelop and cart icons as well. Turn the filter off to show just the social networks for ease of use in finding them. Actually, just leave it off as default so the user experience is still the same.

@arielk
Copy link
Member

arielk commented Mar 14, 2017

It's a little tricky, if you have specific icons missing you, please write to us and we will add.

@arielk arielk closed this as completed Mar 14, 2017
@pingram3541
Copy link
Contributor Author

Do you prefer direct via Pro support on the website or just ask here?

I provided two icon types I'd like to see, one for email links and another for shopping cart links. In some cases it makes sense to combine these into the same widget space as social links for design cohesion.

For now I am using custom css to convert the icons but it is much pain to do and customer cannot edit without confusion because it appears as a social network they are not using in the editor.

i.e. I use pseudo elements in custom css to accomplish but can also cause a FOUC during page load which is undesirable. Thx

@arielk
Copy link
Member

arielk commented Mar 14, 2017

You can ask here :)

Latest PR for the social icons widget with new icons:
#1417
#1273
#955

@pingram3541
Copy link
Contributor Author

Thanks, I've added them both =)

#1463
#1462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants