Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… 🐞 Bug Report: Loop item container not respecting min-height if HTML tag is A - [ED-11293] #22678

Closed
5 tasks done
tomas-eklund opened this issue Jun 5, 2023 · 3 comments
Labels
bug Indicates a bug with one or multiple components. mod* product/pro Indicates if the referenced component is part of the Elementor Pro plugin. solved Indicates that an Issue has been Solved, or a Feature Request has been Released. status/merged Indicates when a Pull Request has been merged to a Release. type/styles Indicates when a topic is related to the styles or design of a component. widget/loop-builder/carousel References the Loop Carousel (Pro) nested widget.
Milestone

Comments

@tomas-eklund
Copy link

tomas-eklund commented Jun 5, 2023

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

I'm using the new container-based Loop Carousel widget to create a slider. I'm making the entire slide into a big clickable area by setting the HTML tag of the outer container to A. I also set the container Min Height to 600px.

image

However, on the front end the entire slider collapses into this sorry mess:

image

After some experimenting I've concluded that I can work around the problem by adding the following custom CSS to the outer container element:

selector {
    display: flex;
}

Steps to reproduce

  1. Add a Loop Carousel
  2. Create the Template
  3. Add an outer container to the template
  4. Set a background color/image (helps illustrate the problem) on the outer container
  5. Set a min height of the outer container to something like 600px
  6. Set the outer container HTML element type to A
  7. Add some content to the template
  8. Save template, publish the page and view it on the front end

Demo here https://elementor.tronica.se/bug-reports/container-of-a-type/
Login can be provided.

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a Blank WordPress theme active (Hello theme).
  • I can reproduce this bug consistently following the steps above.

System Info

System Info
					
== Server Environment ==
	Operating System: Linux
	Software: Apache
	MySQL version: MariaDB Server v10.5.18
	PHP Version: 8.1.19
	PHP Memory Limit: 128M
	PHP Max Input Vars: 1000
	PHP Max Post Size: 16M
	GD Installed: Yes
	ZIP Installed: Yes
	Write Permissions: All right
	Elementor Library: Connected

== WordPress Environment ==
	Version: 6.2.2
	Site URL: https://www.rockdale.se
	Home URL: https://www.rockdale.se
	WP Multisite: No
	Max Upload Size: 16 MB
	Memory limit: 40M
	Max Memory limit: 256M
	Permalink Structure: /%postname%/
	Language: en-US
	Timezone: Europe/Stockholm
	Admin Email: [REDACTED]
	Debug Mode: Inactive

== Theme ==
	Name: Hello Elementor
	Version: 2.7.1
	Author: Elementor Team
	Child Theme: No

== User ==
	Role: administrator
	WP Profile lang: sv_SE
	User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36

== Active Plugins ==
	Elementor
		Version: 3.13.4
		Author: Elementor.com

	Elementor Pro
		Version: 3.13.2
		Author: Elementor.com


== Features ==
	Custom Fonts: 2
	Custom Icons: 0

== Integrations ==
	


== Elementor Experiments ==
	Optimized DOM Output: Active by default
	Improved Asset Loading: Inactive
	Improved CSS Loading: Inactive
	Inline Font Icons: Inactive by default
	Accessibility Improvements: Active by default
	Additional Custom Breakpoints: Active by default
	admin_menu_rearrangement: Inactive by default
	Flexbox Container: Active
	Upgrade Swiper Library: Active by default
	Grid Container: Inactive by default
	Default to New Theme Builder: Active by default
	Hello Theme Header & Footer: Inactive
	Editor Top Bar: Active
	Landing Pages: Inactive
	Nested Elements: Active
	Lazy Load Background Images: Inactive by default
	Page Transitions: Active by default
	Notes: Active by default
	Loop: Active by default
	Form Submissions: Active by default
	Scroll Snap: Active by default
	Menu: Inactive by default


== Log ==
	
PHP: showing 9 of 9PHP: 2023-04-24 13:49:21 [notice X 1][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor/core/upgrade/manager.php::63] version_compare(): Passing null to parameter #1 ($version1) of type string is deprecated [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-04-24 13:50:26 [notice X 99417][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/modules/loop-builder/module.php::200] strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-04-24 14:20:17 [warning X 1][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor/core/files/file-types/svg.php::234] simplexml_load_file(): I/O warning : failed to load external entity "https://www.rockdale.se/wp-content/uploads/Notera2-Medium.svg" [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-04-24 15:08:19 [warning X 9][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor/core/common/modules/ajax/module.php::175] Undefined array key "data" [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-05-29 14:11:18 [warning X 17][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor/modules/history/revisions-manager.php::363] Trying to access array offset on value of type null [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-06-01 13:57:51 [warning X 9][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/modules/dynamic-tags/pods/tags/pods-text.php::20] Trying to access array offset on value of type bool [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-06-02 10:56:05 [warning X 13][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/modules/theme-builder/classes/conditions-manager.php::171] Undefined array key "editor_post_id" [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-06-02 14:15:16 [warning X 3][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/core/app/modules/site-editor/data/endpoints/templates.php::150] Undefined array key "condition_type" [array (
  'trace' => '
#0: /home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/core/app/modules/site-editor/data/endpoints/templates.php(150): Elementor\Core\Logger\Manager -> rest_error_handler()
#1: ElementorPro\Core\App\Modules\SiteEditor\Data\Endpoints\Templates -> normalize_template_json_item()
#2: /home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/core/app/modules/site-editor/data/endpoints/templates.php(120): class type array_map()
#3: /home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/core/app/modules/site-editor/data/endpoints/templates.php(59): ElementorPro\Core\App\Modules\SiteEditor\Data\Endpoints\Templates -> normalize_templates_json()
#4: /home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor/data/base/endpoint.php(158): ElementorPro\Core\App\Modules\SiteEditor\Data\Endpoints\Templates -> get_items()
',
)]
PHP: 2023-06-05 14:34:47 [warning X 2][/home/vhosts/rockdale.se/httpdocs/wp-content/plugins/elementor-pro/modules/query-control/classes/elementor-post-query.php::247] Undefined property: WP_Error::$taxonomy [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]

Log: showing 20 of 202023-05-03 15:39:22 [info] elementor-pro::elementor_pro_updater Started 
2023-05-03 15:39:22 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-05-03 15:39:22 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-05-03 15:39:22 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.11.3',
  'to' => '3.12.3',
)]
2023-05-03 15:39:22 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.11.3',
  'to' => '3.12.3',
)]
2023-05-25 15:31:33 [info] elementor-pro::elementor_pro_updater Started 
2023-05-25 15:31:33 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-05-25 15:31:33 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-05-25 15:31:33 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.12.3',
  'to' => '3.13.2',
)]
2023-05-25 15:31:33 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.12.3',
  'to' => '3.13.2',
)]
2023-05-25 15:33:27 [info] elementor::elementor_updater Started 
2023-05-25 15:33:27 [info] Elementor/Upgrades - _on_each_version Start  
2023-05-25 15:33:27 [info] Elementor/Upgrades - _on_each_version Finished 
2023-05-25 15:33:27 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor',
  'from' => '3.12.2',
  'to' => '3.13.3',
)]
2023-05-25 15:33:27 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor',
  'from' => '3.12.2',
  'to' => '3.13.3',
)]
2023-05-29 14:12:51 [info] elementor::elementor_updater Started 
2023-05-29 14:12:51 [info] Elementor/Upgrades - _on_each_version Start  
2023-05-29 14:12:51 [info] Elementor/Upgrades - _on_each_version Finished 
2023-05-29 14:12:51 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor',
  'from' => '3.13.3',
  'to' => '3.13.4',
)]
2023-05-29 14:12:51 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor',
  'from' => '3.13.3',
  'to' => '3.13.4',
)]

JS: showing 8 of 8JS: 2023-06-02 08:54:27 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view29620") has already been destroyed and cannot be used. 
JS: 2023-06-02 09:10:19 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/js/editor.min.js?ver=3.13.4:3:1097282] Cannot read properties of null (reading 'getBoundingClientRect') 
JS: 2023-06-02 09:39:39 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view1245") has already been destroyed and cannot be used. 
JS: 2023-06-02 12:27:55 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view5607") has already been destroyed and cannot be used. 
JS: 2023-06-02 12:49:00 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view120") has already been destroyed and cannot be used. 
JS: 2023-06-02 13:04:11 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view181") has already been destroyed and cannot be used. 
JS: 2023-06-02 13:09:26 [error X 1][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view12618") has already been destroyed and cannot be used. 
JS: 2023-06-02 13:32:14 [error X 2][https://www.rockdale.se/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5.e1:24:19952] View (cid: "view185") has already been destroyed and cannot be used. 



== Elementor - Compatibility Tag ==
	
	Elementor Pro: Compatible

== Elementor Pro - Compatibility Tag ==
	

				
@tomas-eklund tomas-eklund added the status/awaiting_triage Indicates when an Issue, Pull Request, or Discussion awaits to be triaged. label Jun 5, 2023
@nicholaszein nicholaszein changed the title Loop item container not respecting min-height if HTML tag is A [🧐 Evaluating] 🐞 Bug Report: Loop item container not respecting min-height if HTML tag is A Jun 5, 2023
@nicholaszein nicholaszein added bug Indicates a bug with one or multiple components. product/pro Indicates if the referenced component is part of the Elementor Pro plugin. component/design widget/loop-builder References the Loop Grid (Pro) widget and any related components. and removed status/awaiting_triage Indicates when an Issue, Pull Request, or Discussion awaits to be triaged. labels Jun 5, 2023
@nicholaszein
Copy link
Contributor

Hello @tomas-eklund!

Thank you for sharing your detailed report, we appreciate it! πŸ™

Please allow us some time to investigate it, and get back to you with our findings. 🧐

Best regards

@nicholaszein nicholaszein added widget/loop-builder/carousel References the Loop Carousel (Pro) nested widget. mod* and removed widget/loop-builder References the Loop Grid (Pro) widget and any related components. labels Jun 5, 2023
@nicholaszein nicholaszein changed the title [🧐 Evaluating] 🐞 Bug Report: Loop item container not respecting min-height if HTML tag is A 🐞 Bug Report: Loop item container not respecting min-height if HTML tag is A - [ED-11293] Jul 4, 2023
@nicholaszein nicholaszein added the status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. label Jul 4, 2023
@nicholaszein
Copy link
Contributor

Hello @tomas-eklund!

We are aware of this issue and our team is already working on a fix. We can’t say exactly when it'll be sorted out, but we kindly ask for your patience. Thanks for understanding! πŸ˜‰

Best regards

@nicholaszein nicholaszein changed the title 🐞 Bug Report: Loop item container not respecting min-height if HTML tag is A - [ED-11293] βœ… 🐞 Bug Report: Loop item container not respecting min-height if HTML tag is A - [ED-11293] Sep 24, 2023
@nicholaszein nicholaszein added status/merged Indicates when a Pull Request has been merged to a Release. solved Indicates that an Issue has been Solved, or a Feature Request has been Released. and removed status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Sep 24, 2023
@nicholaszein nicholaszein added this to the 3.16.0 milestone Sep 24, 2023
@nicholaszein
Copy link
Contributor

Hello there @tomas-eklud!

We have great news! πŸ™Œ

πŸ“’ We're happy to announce that the issue you raised was resolved in Elementor Pro v3.16! πŸ₯³

βœ… Feel free to check it out and update your plugin to the new version!

Check the changelog for more information:
Changelog of Elementor and Elementor Pro

Cheers πŸ₯‚

@elementor elementor locked and limited conversation to collaborators Sep 24, 2023
@nicholaszein nicholaszein added the type/styles Indicates when a topic is related to the styles or design of a component. label Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Indicates a bug with one or multiple components. mod* product/pro Indicates if the referenced component is part of the Elementor Pro plugin. solved Indicates that an Issue has been Solved, or a Feature Request has been Released. status/merged Indicates when a Pull Request has been merged to a Release. type/styles Indicates when a topic is related to the styles or design of a component. widget/loop-builder/carousel References the Loop Carousel (Pro) nested widget.
Projects
None yet
Development

No branches or pull requests

2 participants