Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛔ 🐞 Bug Report: Hello <=2.8.1 + Elementor <= 3.15.1 - Footer is not empty by default #23376

Closed
5 tasks done
mateitudor opened this issue Aug 10, 2023 · 1 comment
Closed
5 tasks done
Labels
document/settings References a Document's (Posts, Pages, Templates, Popups, etc.) settings. mod* product/pro Indicates if the referenced component is part of the Elementor Pro plugin. theme-builder/footer-template References any Footer template feature of Elementor Pro’s Theme Builder. theme-builder/header-template References any Header template feature of Elementor Pro’s Theme Builder. theme-builder References any component related to Elementor Pro’s Theme Builder. type/layout Indicates when a topic is related to a component’s Layout.

Comments

@mateitudor
Copy link

mateitudor commented Aug 10, 2023

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

When one wants a page with only a header and no footer, the footer cannot be easily hidden / disabled when using the "Theme" Page Layout.

This is what outputs (notice the non-empty space):
<footer id="site-footer" class="site-footer" role="contentinfo"> </footer>

Ideal outcome: no footer will be rendered in the markup, unless:

  1. A template is specified using Display Conditions;
  2. A widget is added through the WordPress interface (i.e. working with the Hello theme page structure).

Less ideal but still usable:

  1. An empty element: <footer id="site-footer" class="site-footer" role="contentinfo"></footer> → this can be targeted through css: .home .site-footer:empty { display: none; }
  2. A class added to the markup: <footer id="site-footer" class="site-footer footer-empty" role="contentinfo"> </footer>

Current (ugly) workaround:
.home .site-footer:not(:has(*)) { display: none; }

Steps to reproduce

  1. Create a simple page;
  2. Create a header that is included on that page;
  3. Don't create a footer;
  4. Pick 'Page Layout' → 'Theme';
  5. Preview the page in the browser & scroll to the footer — you will see a vertical space.

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a Blank WordPress theme active (Hello theme).
  • I can reproduce this bug consistently following the steps above.

System Info

Click to reveal
					
== Server Environment ==
	Operating System: Darwin
	Software: nginx/1.16.0
	MySQL version: MySQL Community Server - GPL v8.0.16
	PHP Version: 8.1.9
	PHP Memory Limit: 256M
	PHP Max Input Vars: 4000
	PHP Max Post Size: 1000M
	GD Installed: Yes
	ZIP Installed: Yes
	Write Permissions: All right
	Elementor Library: Connected

== WordPress Environment ==
	Version: 6.3
	Site URL: http://interior19studio.local
	Home URL: http://interior19studio.local
	WP Multisite: No
	Max Upload Size: 300 MB
	Memory limit: 40M
	Max Memory limit: 256M
	Permalink Structure: /%postname%/
	Language: en-US
	Timezone: Europe/Bucharest
	Debug Mode: Inactive

== Theme ==
	Name: Interior19 Studio
	Version: 1.0.0
	Author: Tudor Matei
	Child Theme: Yes
	Parent Theme Name: Hello Elementor
	Parent Theme Version: 2.8.1
	Parent Theme Author: Elementor Team

== User ==
	Role: administrator
	WP Profile lang: en_US
	User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15

== Active Plugins ==
	All-in-One WP Migration
		Version: 7.77
		Author: ServMask

	All-in-One WP Migration Unlimited Extension
		Version: 2.52
		Author: ServMask

	Change wp-admin login
		Version: 1.1.7
		Author: wpexpertsio

	Elementor
		Version: 3.15.1
		Author: Elementor.com

	Elementor Beta (Developer Edition)
		Version: 1.1.1
		Author: Elementor.com

	Elementor Pro
		Version: 3.15.1
		Author: Elementor.com

	Jetpack
		Version: 12.4
		Author: Automattic

	LiteSpeed Cache
		Version: 5.5.1
		Author: LiteSpeed Technologies

	ManageWP - Worker
		Version: 4.9.17
		Author: GoDaddy

	Nested Pages
		Version: 3.2.4
		Author: Kyle Phillips

	Rank Math SEO
		Version: 1.0.121
		Author: Rank Math

	Rank Math SEO PRO
		Version: 3.0.37
		Author: Rank Math

	WP Mail SMTP
		Version: 3.8.2
		Author: WP Mail SMTP


== Must-Use Plugins ==
	ManageWP - Worker Loader
		Version: 1.0.0
		Author: GoDaddy


== Elements Usage ==
	
	footer : 1
		container : 1
		divider : 1
		text-editor : 1
	header : 2
		container : 12
		mega-menu : 2
	wp-page : 3
		button : 1
		container : 11
		divider : 2
		heading : 7
		icon-list : 1
		image : 1
		nested-carousel : 1
		text-editor : 3


== Settings ==
	
	cpt_support: post, page
	disable_color_schemes: yes
	disable_typography_schemes: yes
	allow_tracking: yes
	unfiltered_files_upload: 1
	meta_generator_tag: 1


== Features ==
	Custom Fonts: 0
	Custom Icons: 0

== Integrations ==
	


== Elementor Experiments ==
	Optimized DOM Output: Active
	Improved Asset Loading: Active
	Improved CSS Loading: Active
	Inline Font Icons: Active
	Additional Custom Breakpoints: Inactive
	admin_menu_rearrangement: Inactive by default
	Flexbox Container: Active
	Upgrade Swiper Library: Active
	Grid Container: Active
	Default to New Theme Builder: Inactive
	Hello Theme Header & Footer: Inactive
	Editor Top Bar: Active
	Landing Pages: Inactive
	Nested Elements: Active
	Lazy Load Background Images: Active
	Global Style Guide: Active
	Page Transitions: Inactive
	Notes: Inactive
	Loop: Active
	Form Submissions: Active
	Scroll Snap: Active
	Menu: Active
	Taxonomy Filter: Active


== Log ==
	
Log: showing 20 of 392023-06-21 23:44:08 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.13.2',
  'to' => '3.14.0',
)]
2023-06-30 17:12:35 [info] elementor-pro::elementor_pro_updater Started 
2023-06-30 17:12:35 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-06-30 17:12:35 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-06-30 17:12:35 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.14.0',
  'to' => '3.14.1',
)]
2023-06-30 17:12:35 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.14.0',
  'to' => '3.14.1',
)]
2023-06-30 17:12:36 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.14.0',
  'to' => '3.14.1',
)]
2023-08-08 16:00:53 [info] elementor::elementor_updater Started 
2023-08-08 16:00:53 [info] Elementor/Upgrades - _on_each_version Start  
2023-08-08 16:00:53 [info] Elementor/Upgrades - _on_each_version Finished 
2023-08-08 16:00:53 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor',
  'from' => '3.14.0',
  'to' => '3.15.1',
)]
2023-08-08 16:00:55 [info] elementor-pro::elementor_pro_updater Started 
2023-08-08 16:00:55 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-08-08 16:00:55 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-08-08 16:00:55 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.14.1',
  'to' => '3.15.0',
)]
2023-08-10 02:51:36 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.15.0',
  'to' => '3.15.1',
)]
2023-08-10 02:51:36 [info] elementor-pro::elementor_pro_updater Started 
2023-08-10 02:51:36 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-08-10 02:51:36 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-08-10 02:51:36 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.15.0',
  'to' => '3.15.1',
)]

PHP: showing 3 of 3PHP: 2023-08-09 00:08:37 [warning X 2][../wp-content/plugins/elementor/app/modules/import-export/module.php::738] Attempt to read property "label" on null [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-08-09 00:08:38 [warning X 2][../wp-content/plugins/elementor/core/common/modules/ajax/module.php::175] Undefined array key "data" [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-08-09 00:40:38 [warning X 2][../wp-content/plugins/elementor-pro/modules/assets-manager/asset-types/fonts-manager.php::252] Undefined array key "editor_post_id" [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]

JS: showing 1 of 1JS: 2023-08-08 21:49:35 [error X 2][http://interior19studio.local/wp-content/plugins/elementor/assets/js/7fada1a61d72da6d46ab.bundle.min.js:2:7826] null is not an object (evaluating 't.target.closest(".elementor").dataset') 



== Elementor - Compatibility Tag ==
	
	Elementor Pro: Compatible

== Elementor Pro - Compatibility Tag ==
	

				
@mateitudor mateitudor added the status/awaiting_triage Indicates when an Issue, Pull Request, or Discussion awaits to be triaged. label Aug 10, 2023
@nicholaszein nicholaszein changed the title 🐞 Bug Report: Hello <=2.8.1 + Elementor <= 3.15.1 - Footer is not empty by default :no~🐞 Bug Report: Hello <=2.8.1 + Elementor <= 3.15.1 - Footer is not empty by default Aug 20, 2023
@nicholaszein nicholaszein changed the title :no~🐞 Bug Report: Hello <=2.8.1 + Elementor <= 3.15.1 - Footer is not empty by default ⛔ 🐞 Bug Report: Hello <=2.8.1 + Elementor <= 3.15.1 - Footer is not empty by default Aug 20, 2023
@nicholaszein nicholaszein added product/pro Indicates if the referenced component is part of the Elementor Pro plugin. theme-builder References any component related to Elementor Pro’s Theme Builder. type/layout Indicates when a topic is related to a component’s Layout. document/settings References a Document's (Posts, Pages, Templates, Popups, etc.) settings. mod* theme-builder/header-template References any Header template feature of Elementor Pro’s Theme Builder. theme-builder/footer-template References any Footer template feature of Elementor Pro’s Theme Builder. and removed status/awaiting_triage Indicates when an Issue, Pull Request, or Discussion awaits to be triaged. labels Aug 20, 2023
@nicholaszein
Copy link
Member

Hello @mateitudor,

Thank you for reaching out! 🙏

⛔ While reviewing your report we concluded this is not an issue caused by Elementor. Here's what we found out:

  • That's the expected behavior. Unless you use the Elementor Canvas Page Template, Single templates should always include the Header and Footer Site parts as indicated by the WordPress Codex.
  • For backward compatibility and compatibility with both themes and plugins, this behavior won\t be changed.
  • The blank space is added by WordPress, not Elementor.

✅ What you can do to solve your issue:

  • If you wish to use a template without a footer you have two options:
    1. Create a Single Page Template, select the Elementor Canvas as the Page Template, and add your Header directly inside the template. This way you have total control over your templates. This is why the Theme Builder exists.
    2. Create a custom Page Template that does not include the Footer Site Part by following the instructions in the Theme Development Standards, and add it to your Child Theme.

👍 For now, that's all we can help with.

Kind regards

@nicholaszein nicholaszein closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2023
@elementor elementor locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
document/settings References a Document's (Posts, Pages, Templates, Popups, etc.) settings. mod* product/pro Indicates if the referenced component is part of the Elementor Pro plugin. theme-builder/footer-template References any Footer template feature of Elementor Pro’s Theme Builder. theme-builder/header-template References any Header template feature of Elementor Pro’s Theme Builder. theme-builder References any component related to Elementor Pro’s Theme Builder. type/layout Indicates when a topic is related to a component’s Layout.
Projects
None yet
Development

No branches or pull requests

2 participants