Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Elementor color control does not allow more than 7 characters #2737

Closed
ddenev opened this issue Nov 12, 2017 · 2 comments
Closed

[Bug] Elementor color control does not allow more than 7 characters #2737

ddenev opened this issue Nov 12, 2017 · 2 comments
Labels
bug Indicates a bug with one or multiple components.

Comments

@ddenev
Copy link

ddenev commented Nov 12, 2017

Hi,

Not allowing more than 7 characters in the color control brings the problem where when I want to manually enter a transparency value for the rgba function, the whole value is rewritten.

I have to say this is NOT a issue with the native WordPress color picker as stated in #1547 .

The following Elementor files have a color control input element with the 'maxlength' attribute set to 7:

  • includes/controls/box-shadow.php
  • includes/controls/color.php
  • includes/controls/text-shadow.php

When I manually set the maxlength to 25 (to accommodate an rgba value, e.g. 'rgba(255,255,255,0.85)') then everything works fine - i.e. I am able to manually set the transparency within the control. When it is set to 7 then all the above problems happen. The problem is every update of Elementor removes my fix.

So, it is not a problem with WordPress. Please set the maxlength to at least 25.

Thank you.

@bainternet bainternet added the bug Indicates a bug with one or multiple components. label Nov 12, 2017
@bainternet
Copy link
Contributor

@drank
thanks for reporting,
should be fixed in 1.8.4 when it comes out.

@ddenev
Copy link
Author

ddenev commented Nov 14, 2017

Thanks a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug with one or multiple components.
Projects
None yet
Development

No branches or pull requests

2 participants