Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Widget - Play Icon: Replace the select control with a switcher control #3262

Merged
merged 1 commit into from Jan 22, 2018

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Jan 21, 2018

Fix #3241

Current

video-play-icon

New

video-play-icon2

@ramiy
Copy link
Contributor Author

ramiy commented Jan 21, 2018

I can also update the text to Show / Hide just like text in the image-overlay control and some other controls in the video options section.

@ramiy
Copy link
Contributor Author

ramiy commented Jan 21, 2018

Also, the commit is backwards compatible as the render() function checks only for active state:

<?php if ( 'yes' === $settings['show_play_icon'] ) : ?>
	<div class="elementor-custom-embed-play">
		<i class="eicon-play" aria-hidden="true"></i>
	</div>
<?php endif; ?>

This is why the 'return_value' => 'yes', was added to the control.

@arielk arielk added this to the 2.0.0 milestone Jan 21, 2018
@KingYes KingYes merged commit 469cf0b into elementor:release/2.0.0 Jan 22, 2018
@ramiy ramiy deleted the video_play_icon branch January 22, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants