Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signmessage #1319

Open
LeoComandini opened this issue Feb 15, 2024 · 1 comment
Open

signmessage #1319

LeoComandini opened this issue Feb 15, 2024 · 1 comment

Comments

@LeoComandini
Copy link
Contributor

There are a few issues/open points with Elements/Liquid signmessage and verifymessage

Are we ok with all of the above? or do we we want to change something?

Do we still want to support message signing in Core?

Do we want to extend message signing and verification to non-p2pkh? Do we want to do it outside Core?


FWIW, here is a summary of what some existing wallets implement

Core GDK Electrum
signmessage bitcoin p2pkh
signmessage bitcoin p2sh-p2wpkh
signmessage bitcoin p2wpkh
verifymessage bitcoin p2pkh
verifymessage bitcoin p2sh-p2wpkh
verifymessage bitcoin p2wpkh
signmessage liquid p2pkh
signmessage liquid p2sh-p2wpkh
signmessage liquid p2wpkh
verifymessage liquid p2pkh
verifymessage liquid p2sh-p2wpkh
verifymessage liquid p2wpkh

Electrum was included in the above table since it was used as a reference to add support for non-p2pkh signing to GDK.

@jmastr
Copy link

jmastr commented Feb 16, 2024

@LeoComandini Thank you so much for kick starting the discussion here and putting in the effort to create this table. Highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants