Don't invoke afterSelect if user entered nothing #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2015 08:05
Added conditional check that makes afterSelect not to be invoked when user entered nothing in the text search field. This prevents from the following scenario: 1. User opens page, clicks inside search field 2. User enters nothing, clicks out of search field 3. 'afterSelect' gets invoked <-- !!! With change introduced in this commit, afterSelect will not get invoked in a scenario described above. However, if user entered anything and then clicked out of text field, afterSelect will be invoked with null param. The same if user cleared previous selection - afterSelect will be invoked with null param.
| @@ -177,8 +177,9 @@ elemicaSuggest 0.9.1-SNAPSHOT | |||
|
|
|||
| if $valueInput.val() == "" | |||
| if noSuggestionMatched($target.val(), afterSelect) | |||
| val = $target.val() | |||
There was a problem hiding this comment.
originalValue perhaps?
added 2 commits
November 5, 2015 07:39
This is just more self-descriptive.
|
Looks good to me! 👍 |
lukaszlenart
added a commit
that referenced
this pull request
Nov 9, 2015
Don't invoke afterSelect if user entered nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #21
Added conditional check that makes
afterSelectnot to be invoked when user entered nothing in the text search field. This prevents from the following scenario:afterSelectgets invoked <-- !!!With change introduced in this PR,
afterSelectwill not get invoked in a scenario described above. However, if user entered anything and then clicked out of text field,afterSelectwill be invoked withnullparam. The same if user cleared previous selection -afterSelectwill be invoked withnullparam.