Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gdtk-cli, cliui): Better version resolving, introduce cliui. #106

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

refactor(gdtk-cli, cliui): Better version resolving, introduce cliui. #106

wants to merge 6 commits into from

Conversation

elenakrittik
Copy link
Owner

@elenakrittik elenakrittik commented Jun 12, 2024 •
edited
Loading

Closes #90

  • Switch away from typed-builder
  • Implement keybind actions for Prompt
  • Reduce usage of generics in Prompt (and SliceView) (it's so bad it broke rustfmt 😢)
  • .collect::<Vec<_>>() + Deref internally and only require an iterator publicly
  • Implement filtering
  • Properly calculate stuff in SliceView

@elenakrittik elenakrittik added pr: feature Implements a feature request s: in progress Work-in-progress c: gdtk-cli Crate: gdtk-cli c: gdtk-gvm Crate: gdtk-gvm a: visuals Area: Visuals (console output) a: codeq Area: Code quality labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a: codeq Area: Code quality a: visuals Area: Visuals (console output) c: gdtk-cli Crate: gdtk-cli c: gdtk-gvm Crate: gdtk-gvm pr: feature Implements a feature request s: in progress Work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Somehow) improve code resposible for gdtk godot * commands.
1 participant
@elenakrittik