This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add retryOnReturnValues and retryOnReturnValuesExcluding #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 345
💛 - Coveralls |
elennick
suggested changes
Feb 2, 2019
| @@ -153,6 +154,32 @@ private void postExecutionCleanup(Callable<T> callable, int maxTries, AttemptSta | |||
| return attemptStatus; | |||
| } | |||
|
|
|||
| private boolean isOneOfValuesToExpect( T callResult ) { | |||
| Object[] valuesToExpect = config.getValuesToExpect(); | |||
There was a problem hiding this comment.
could you format these blocks to be consistent with code styling in the rest of the class? eg: less whitespace and line breaks
|
|
||
| @SafeVarargs | ||
| public final RetryConfigBuilder retryOnReturnValues(Object... values) { | ||
| retryOnValue = true; |
There was a problem hiding this comment.
i would generally prefer wrapping these with a Collection of some sort rather than storing them as a raw array... for example: https://github.com/elennick/retry4j/pull/79/files#diff-25b653eb79d0323ac9625faf0ae65ef9R101
There was a problem hiding this comment.
Fair enough. Updated.
|
Thanks for the review and I updated accordingly. |
|
@ruhan1 any chance you wouldn't mind updating the README as well to reflect the new API's you added? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need two more APIs in RetryConfigBuilder. The retryOnReturnValues takes an array of retriable values. The retryOnReturnValuesExcluding handles the case where I only expect certain return value(s). E.g., only "200" for a REST call and retry for any other status codes.
Can anyone help review this?