fix: disabling bot crawling on staging and refactor sitemap to add da…

…tes and images
eleven-labs · Apr 11, 2024 · ac09a3a · ac09a3a
1 parent 36285e3
commit ac09a3a
Show file tree

Hide file tree

Showing 11 changed files with 128 additions and 67 deletions.
diff --git a/public/robots.txt b/public/robots.txt
diff --git a/src/constants.ts b/src/constants.ts
@@ -3,6 +3,7 @@ import { getEnv } from '@/helpers/getEnvHelper';
 export const IS_SSR = import.meta.env?.SSR ?? false;
 export const IS_PRERENDER = import.meta.env?.MODE === 'prerender';
 export const HOST_URL = getEnv<string>('VITE_HOST_URL') || 'https://blog.eleven-labs.com';
+export const IS_ENV_PRODUCTION = HOST_URL === 'https://blog.eleven-labs.com';
 export const BASE_URL = import.meta.env?.BASE_URL || '/';
 
 export const IS_DEBUG = getEnv<string>('VITE_IS_DEBUG') === 'true';

diff --git a/src/helpers/assetHelper.ts b/src/helpers/assetHelper.ts
@@ -24,7 +24,7 @@ export const getCoverPath = ({
   device: DeviceEnum;
   pixelRatio: number;
 }): string => {
-  const isProd: boolean = process.env.NODE_ENV === 'production';
+  const isProd: boolean = true; //process.env.NODE_ENV === 'production';
   const directoryPath = dirname(path);
   const filename = basename(path, extname(path));
   const imageFormat = IMAGE_FORMATS[device][format];

diff --git a/src/helpers/prerenderHelper/generateRobotsTxt.ts b/src/helpers/prerenderHelper/generateRobotsTxt.ts
@@ -0,0 +1,17 @@
+import { writeFileSync } from 'node:fs';
+import { resolve } from 'node:path';
+
+import { HOST_URL, IS_ENV_PRODUCTION } from '@/constants';
+
+export const getRobotsTxt = (): string => {
+  return (
+    IS_ENV_PRODUCTION
+      ? ['User-agent: *', 'Allow: /', `Sitemap: ${HOST_URL}/sitemap.xml`]
+      : ['User-agent: *', 'Disallow: /']
+  ).join('\n');
+};
+
+export const generateRobotsTxt = async (options: { rootDir: string }): Promise<void> => {
+  const robotsTxt = getRobotsTxt();
+  writeFileSync(resolve(options.rootDir, 'robots.txt'), robotsTxt, 'utf8');
+};
diff --git a/src/helpers/prerenderHelper/generateSitemap.ts b/src/helpers/prerenderHelper/generateSitemap.ts
@@ -4,24 +4,32 @@ import * as xml2js from 'xml2js';
 
 import { blogUrl } from '@/config/website';
 import { DEFAULT_LANGUAGE } from '@/constants';
+import type { SitemapEntry } from '@/helpers/prerenderHelper/getSitemapEntries';
 
-export const getSitemap = (
-  sitemapEntries: { links: { lang: string; url: string }[]; changefreq?: string; priority?: number }[]
-): string => {
+export const getSitemap = (sitemapEntries: SitemapEntry[]): string => {
   const builder = new xml2js.Builder();
   return builder.buildObject({
     urlset: {
       $: {
         xmlns: 'http://www.sitemaps.org/schemas/sitemap/0.9',
         'xmlns:xhtml': 'http://www.w3.org/1999/xhtml',
-        'xmlns:news': 'http://www.google.com/schemas/sitemap-news/0.9',
+        'xmlns:image': 'http://www.google.com/schemas/sitemap-image/1.1',
       },
-      url: sitemapEntries.map(({ links, priority, changefreq }) => {
+      url: sitemapEntries.map(({ links, priority, changeFrequency, lastModified, image }) => {
         const defaultLink = links.find((link) => link.lang === DEFAULT_LANGUAGE) ?? links[0];
         return {
           loc: `${blogUrl}${defaultLink.url}`,
-          ...(changefreq ? { changefreq } : {}),
-          priority: priority?.toFixed(1) ?? 0.3,
+          ...(lastModified ? { lastmod: lastModified } : {}),
+          ...(changeFrequency ? { changefreq: changeFrequency } : {}),
+          ...(priority ? { priority } : {}),
+          ...(image
+            ? {
+                'image:image': {
+                  'image:loc': `${blogUrl}${image.url}`,
+                  ...(image.description ? { 'image:caption': image.description } : {}),
+                },
+              }
+            : {}),
           ...(links.length > 1
             ? {
                 'xhtml:link': links.map((link) => ({

diff --git a/src/helpers/prerenderHelper/getSitemapEntries.test.ts b/src/helpers/prerenderHelper/getSitemapEntries.test.ts
@@ -1,4 +1,4 @@
-import { getSitemapEntries } from './getSitemapEntries';
+import { getSitemapEntries, SitemapEntry } from './getSitemapEntries';
 
 describe('getSitemapEntries', () => {
   test('should generate sitemap entries correctly', () => {
@@ -12,38 +12,53 @@ describe('getSitemapEntries', () => {
       };
     });
     vi.mock('@/helpers/markdownContentManagerHelper', () => ({
-      getPosts: (): { lang: string; slug: string; categories: string[]; authors: string[] }[] => [
-        { lang: 'fr', slug: 'post-1', categories: ['architecture'], authors: ['author-1'] },
-        { lang: 'en', slug: 'post-2', categories: ['php'], authors: ['author-1'] },
+      getPosts: (): {
+        lang: string;
+        slug: string;
+        categories: string[];
+        authors: string[];
+        date: string;
+        cover?: { path: string };
+      }[] => [
+        {
+          lang: 'fr',
+          slug: 'post-1',
+          categories: ['architecture'],
+          authors: ['author-1'],
+          date: '2024-01-01T00:00:00',
+          cover: { path: '/imgs/post-1/cover.png' },
+        },
+        { lang: 'en', slug: 'post-2', categories: ['php'], authors: ['author-1'], date: '2024-01-01T00:00:00' },
       ],
       getAuthors: (): { username: string }[] => [{ username: 'author-1' }],
     }));
 
     // Expected result
-    const expectedSitemapEntries = [
-      { priority: 1, links: [{ lang: 'fr', url: '/fr/post-1/' }] },
-      { priority: 1, links: [{ lang: 'en', url: '/en/post-2/' }] },
+    const expectedSitemapEntries: SitemapEntry[] = [
       {
-        priority: 0.8,
-        changefreq: 'weekly',
+        links: [{ lang: 'fr', url: '/fr/post-1/' }],
+        lastModified: '2024-01-01T00:00:00',
+        image: { url: '/imgs/post-1/cover-w400-h245-x2.avif' },
+      },
+      { links: [{ lang: 'en', url: '/en/post-2/' }], lastModified: '2024-01-01T00:00:00' },
+      {
+        changeFrequency: 'weekly',
         links: [
           { lang: 'fr', url: '/' },
           { lang: 'fr', url: '/fr/' },
           { lang: 'en', url: '/en/' },
         ],
       },
       {
-        priority: 0.7,
-        changefreq: 'weekly',
+        changeFrequency: 'weekly',
         links: [
           { lang: 'fr', url: '/fr/categories/all/' },
           { lang: 'en', url: '/en/categories/all/' },
         ],
       },
-      { priority: 0.7, changefreq: 'weekly', links: [{ lang: 'en', url: '/en/categories/php/' }] },
-      { priority: 0.7, changefreq: 'weekly', links: [{ lang: 'fr', url: '/fr/categories/architecture/' }] },
+      { changeFrequency: 'weekly', links: [{ lang: 'en', url: '/en/categories/php/' }] },
+      { changeFrequency: 'weekly', links: [{ lang: 'fr', url: '/fr/categories/architecture/' }] },
       {
-        priority: 0.5,
         links: [
           { lang: 'fr', url: '/fr/authors/author-1/' },
           { lang: 'en', url: '/en/authors/author-1/' },

diff --git a/src/helpers/prerenderHelper/getSitemapEntries.ts b/src/helpers/prerenderHelper/getSitemapEntries.ts
@@ -1,59 +1,73 @@
+import { DeviceEnum, ImageFormatEnum, PATHS } from '@/constants';
+import { getCoverPath } from '@/helpers/assetHelper';
 import { getAuthors, getPosts } from '@/helpers/markdownContentManagerHelper';
 import {
   getAuthorPageUrls,
   getCategoryPageUrls,
   getHomePageUrls,
-  getPostPageUrls,
   getTutorialStepPageUrls,
 } from '@/helpers/prerenderHelper/getUrls';
+import { generatePath } from '@/helpers/routerHelper';
 
-type Link = {
-  lang: string;
-  url: string;
-};
-
-type SitemapEntry = {
-  links: Link[];
-  changefreq?: string;
-  priority: number;
-};
+export interface SitemapEntry {
+  links: {
+    lang: string;
+    url: string;
+  }[];
+  image?: {
+    url: string;
+    description?: string;
+  };
+  lastModified?: string;
+  changeFrequency?: 'always' | 'hourly' | 'daily' | 'weekly' | 'monthly' | 'yearly' | 'never';
+  priority?: number;
+}
 
 export const getSitemapEntries = (): SitemapEntry[] => {
   const posts = getPosts();
   const authors = getAuthors();
 
   const rootEntry: SitemapEntry = {
-    priority: 0.8,
     links: getHomePageUrls(),
-    changefreq: 'weekly',
+    changeFrequency: 'weekly',
   };
 
   const categoryPageUrls = getCategoryPageUrls(posts);
   const categoryEntries: SitemapEntry[] = categoryPageUrls.map((urls) => ({
-    priority: 0.7,
     links: urls,
-    changefreq: 'weekly',
+    changeFrequency: 'weekly',
   }));
 
   const authorPageUrls = getAuthorPageUrls(posts, authors);
   const authorEntries: SitemapEntry[] = authorPageUrls.map((urls) => ({
-    priority: 0.5,
     links: urls,
   }));
 
-  const postPageUrls = getPostPageUrls(posts);
-  const postEntries: SitemapEntry[] = postPageUrls.map((urls) => ({
-    priority: 1,
-    links: urls,
+  const postEntries: SitemapEntry[] = posts.map((post) => ({
+    links: [
+      {
+        lang: post.lang,
+        url: generatePath(PATHS.POST, { lang: post.lang, slug: post.slug }),
+      },
+    ],
+    lastModified: post.date,
+    image: post.cover?.path
+      ? {
+          url: getCoverPath({
+            path: post.cover?.path,
+            format: ImageFormatEnum.HIGHLIGHTED_TUTORIAL_POST_CARD_COVER,
+            pixelRatio: 2,
+            device: DeviceEnum.DESKTOP,
+          }),
+          description: post.cover?.alt,
+        }
+      : undefined,
   }));
 
   const tutorialStepUrls = getTutorialStepPageUrls(posts);
   const tutorialStepEntries: SitemapEntry[] = tutorialStepUrls.map((urls) => ({
-    priority: 0.9,
     links: urls,
   }));
 
-  return [rootEntry, ...categoryEntries, ...authorEntries, ...postEntries, ...tutorialStepEntries].sort(
-    (a, b) => b?.priority - a?.priority
-  );
+  return [...postEntries, rootEntry, ...categoryEntries, ...authorEntries, ...tutorialStepEntries];
 };
diff --git a/src/helpers/prerenderHelper/getUrls.ts b/src/helpers/prerenderHelper/getUrls.ts
@@ -141,7 +141,7 @@ export const getAuthorPageUrls = (
   return Object.values(urls);
 };
 
-export const getPostPageUrls = (postsData: Pick<TransformedPostData, 'lang' | 'slug'>[]): Urls =>
+export const getPostPageUrls = (postsData: Pick<TransformedPostData, 'lang' | 'slug' | 'date'>[]): Urls =>
   postsData.map((post) => [
     {
       lang: post.lang,

diff --git a/src/helpers/prerenderHelper/index.ts b/src/helpers/prerenderHelper/index.ts
@@ -1,6 +1,7 @@
 import { resolve } from 'node:path';
 
 import { DEFAULT_LANGUAGE, LANGUAGES_AVAILABLE, PATHS } from '@/constants';
+import { generateRobotsTxt } from '@/helpers/prerenderHelper/generateRobotsTxt';
 import { generatePath } from '@/helpers/routerHelper';
 
 import { generateFeedFile } from './generateFeedFile';
@@ -41,6 +42,9 @@ export const generateFiles = async (options: { rootDir: string; baseUrl: string
       rootDir: __dirname,
       sitemapEntries,
     }),
+    generateRobotsTxt({
+      rootDir: __dirname,
+    }),
   ]);
   generateFeedFile({ rootDir: __dirname });
 

diff --git a/src/middlewares/imageMiddleware.ts → src/requestHandlers/imageHandler.ts b/src/middlewares/imageMiddleware.ts → src/requestHandlers/imageHandler.ts
@@ -1,4 +1,4 @@
-import type { Request, Response } from 'express';
+import type { RequestHandler } from 'express';
 import mime from 'mime';
 import { existsSync, readFileSync } from 'node:fs';
 import { resolve } from 'node:path';
@@ -14,7 +14,7 @@ const contentTypesByFormat = {
 
 type FormatEnum = keyof typeof contentTypesByFormat;
 
-export const imageMiddleware = async (req: Request, res: Response): Promise<unknown> => {
+export const imageHandler: RequestHandler = async (req, res) => {
   try {
     const imagePath = resolve(process.cwd(), 'public', req.path.slice(1) as string);
     if (!existsSync(imagePath)) {

diff --git a/src/server.ts b/src/server.ts
@@ -1,5 +1,5 @@
 import chokidar from 'chokidar';
-import express from 'express';
+import express, { RequestHandler } from 'express';
 import i18next from 'i18next';
 import i18nextHttpMiddleware from 'i18next-http-middleware';
 import { cpSync, statSync } from 'node:fs';
@@ -12,13 +12,25 @@ import { i18nResources } from '@/config/i18n/i18nResources';
 import { BASE_URL } from '@/constants';
 import { writeJsonDataFiles } from '@/helpers/contentHelper';
 import { loadDataByMarkdownFilePath } from '@/helpers/markdownContentManagerHelper';
+import { getRobotsTxt } from '@/helpers/prerenderHelper/generateRobotsTxt';
 import { getSitemap } from '@/helpers/prerenderHelper/generateSitemap';
 import { getSitemapEntries } from '@/helpers/prerenderHelper/getSitemapEntries';
 import { createRequestByExpressRequest } from '@/helpers/requestHelper';
-import { imageMiddleware } from '@/middlewares/imageMiddleware';
+import { imageHandler } from '@/requestHandlers/imageHandler';
 
 const isProd: boolean = process.env.NODE_ENV === 'production';
 
+const robotsTxtHandler: RequestHandler = (_, res) => {
+  const robotsTxt = getRobotsTxt();
+  res.status(200).set({ 'Content-Type': 'text/plain' }).end(robotsTxt);
+};
+
+const sitemapHandler: RequestHandler = (_, res) => {
+  const sitemapEntries = getSitemapEntries();
+  const sitemap = getSitemap(sitemapEntries);
+  res.status(200).set({ 'Content-Type': 'text/xml' }).end(sitemap);
+};
+
 const createServer = async (): Promise<void> => {
   i18next.use(i18nextHttpMiddleware.LanguageDetector).init({
     ...i18nConfig,
@@ -41,13 +53,10 @@ const createServer = async (): Promise<void> => {
       dirname: __dirname,
     });
 
+    app.get(/\/imgs\//, imageHandler);
     app.use(BASE_URL, serveStatic(__dirname, { index: false }));
-
-    app.get('/sitemap.xml', (_, res) => {
-      const sitemapEntries = getSitemapEntries();
-      const sitemap = getSitemap(sitemapEntries);
-      res.status(200).set({ 'Content-Type': 'text/xml' }).end(sitemap);
-    });
+    app.get('/robots.txt', robotsTxtHandler);
+    app.get('/sitemap.xml', sitemapHandler);
 
     app.use('*', async (req, res, next) => {
       try {
@@ -93,14 +102,10 @@ const createServer = async (): Promise<void> => {
       });
     });
 
-    app.get(/\/imgs\//, imageMiddleware);
+    app.get(/\/imgs\//, imageHandler);
     app.use(vite.middlewares);
-
-    app.get('/sitemap.xml', (_, res) => {
-      const sitemapEntries = getSitemapEntries();
-      const sitemap = getSitemap(sitemapEntries);
-      res.status(200).set({ 'Content-Type': 'text/xml' }).end(sitemap);
-    });
+    app.get('/robots.txt', robotsTxtHandler);
+    app.get('/sitemap.xml', sitemapHandler);
 
     app.use('*', async (req, res, next) => {
       const url = req.originalUrl;