Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action) Rename cloudfront distribustion id sercret name #1070

Merged

Conversation

nicolas-grevin
Copy link
Contributor

No description provided.

@nicolas-grevin nicolas-grevin force-pushed the fix/action_cloudfront-distribuction-id-secret-name branch from 34ae3e1 to e91d2ad Compare February 23, 2024 15:35
@github-actions github-actions bot temporarily deployed to dev-fix/action_cloudfront-distribuction-id-secret-name February 23, 2024 15:37 Destroyed
Copy link
Contributor

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix/action_cloudfront-distribuction-id-secret-name/ 🟠 73 🟢 100 🟢 92 🟢 92 🟠 70
/fix/action_cloudfront-distribuction-id-secret-name/fr/authors/ajacquemin/ 🟠 89 🟢 100 🟢 92 🟢 92 🟠 70
/fix/action_cloudfront-distribuction-id-secret-name/fr/comment-construire-site-web-avec-nextjs/ 🟠 75 🟢 98 🟠 83 🟢 100 🟠 70
/fix/action_cloudfront-distribuction-id-secret-name/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 63 🟢 98 🟠 83 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/fix/action_cloudfront-distribuction-id-secret-name/ 🔴 3499 🔴 3530 🔴 3499 🔴 5207 🟢 7 🟢 0
/fix/action_cloudfront-distribuction-id-secret-name/fr/authors/ajacquemin/ 🔴 2620 🔴 2620 🟢 2621 🔴 5155 🟢 7 🟢 0
/fix/action_cloudfront-distribuction-id-secret-name/fr/comment-construire-site-web-avec-nextjs/ 🔴 3509 🔴 3510 🔴 3509 🔴 10218 🟢 8 🟢 0
/fix/action_cloudfront-distribuction-id-secret-name/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 3218 🔴 5999 🟢 3218 🔴 6863 🟢 8 🟢 0.09

@nicolas-grevin nicolas-grevin merged commit 251b7e0 into master Feb 23, 2024
2 checks passed
@nicolas-grevin nicolas-grevin deleted the fix/action_cloudfront-distribuction-id-secret-name branch February 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant