Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crumbling FAR2L interface in FreeBSD terminal #929

Closed
alexax66 opened this issue Feb 25, 2021 · 13 comments
Closed

Crumbling FAR2L interface in FreeBSD terminal #929

alexax66 opened this issue Feb 25, 2021 · 13 comments

Comments

@alexax66
Copy link
Contributor

FreeBSD terminal has the same bug as linux #925

I builded FAR2L after exceptions #ifdef __linux__ .... #endif (leaving only support_esc_b = false; // #925) in commit 6df46a6#diff-bc6399fcd63a16b361767c29da77df028799bd78c06c08c3732e5d89d20d8febR226-R231 and this bug disappeared.

@elfmz
Copy link
Owner

elfmz commented Feb 25, 2021

Check now plz

@alexax66
Copy link
Contributor Author

alexax66 commented Feb 26, 2021

Made new build after commit 6fef7c4
Unsuccessfully, the same issue
If run FAR2L from under the tmux, it works flawlessly

@elfmz
Copy link
Owner

elfmz commented Feb 26, 2021

Nice, BSD terminal tells in $TERM that its xterm while doesn't even able to behave as xterm...

@elfmz elfmz closed this as completed in 8661190 Feb 26, 2021
@unxed
Copy link
Contributor

unxed commented Feb 26, 2021

Those spaces compression... aren't compression already done by ssh?

@elfmz
Copy link
Owner

elfmz commented Feb 26, 2021

By default - no.
Even if enable it by running ssh with -C arg - still that sequences reduces multiple Ctrl+O traffic by 1.5..2 times by comparing to sending plain spaces. I measured that by running SSH via socat with enabled traffic loggin.

@unxed
Copy link
Contributor

unxed commented Feb 26, 2021

By default - no.
Even if enable it by running ssh with -C arg - still that sequences reduces multiple Ctrl+O traffic by 1.5..2 times by comparing to sending plain spaces. I measured that by running SSH via socat with enabled traffic loggin.

Got it, thanks!
btw, is there any way to enable ssh compression in NetRocks?

@elfmz
Copy link
Owner

elfmz commented Feb 26, 2021

nope, but will be

@unxed
Copy link
Contributor

unxed commented Feb 26, 2021

Doesn't it follow "Compression yes" from /etc/ssh/ssh_config?

@elfmz
Copy link
Owner

elfmz commented Feb 26, 2021

Looks like libssh is able to parse that file - there is function ssh_options_parse_config. But it doesnt do that by default.
Anyway, IMHO such an option better to be controlled on per-connection settings. For servers inside LAN compression may only make things slower.

@unxed
Copy link
Contributor

unxed commented Feb 26, 2021

And what about other options from that file, like Ciphers? No way to disable compromised cipher without rebuilding?

@elfmz
Copy link
Owner

elfmz commented Feb 26, 2021

Best is the enemy of good. When it will be really needed - it will be too late will implement. Problem is that ciphers list must be obtained dynamically from libssh, and its not very aligns with current arch where protocol implementation completely detached from NetBox plugin SO.

@elfmz
Copy link
Owner

elfmz commented Feb 26, 2021

Ok, added an option to use OpenSSH configs. So such problems can be resolved by checking checkbox and writing bad ciphers in config.

@unxed
Copy link
Contributor

unxed commented Feb 26, 2021

Ok, added an option to use OpenSSH configs. So such problems can be resolved by checking checkbox and writing bad ciphers in config.

Cool, this is exactly the option I wanted! And what if I enable Compression in NetRocks, but disable in OpenSSH config used? Or vice versa. Such behavior should be documented, I guess, not to confuse users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants