New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not ignore error while sending starting message #126

Merged

loyd merged 1 commit into elfo-rs:master from Arjentix:master

May 11, 2024

Contributor

Arjentix commented May 3, 2024

Thanks to @sargarass.

This fix passes my test: https://github.com/Arjentix/elfo-bug

Closes: #125


          fix(core): do not ignore error while sending starting message

8abf4c0

Arjentix force-pushed the master branch from 47bedf2 to 8abf4c0 Compare

May 3, 2024 22:30

Collaborator

loyd commented May 11, 2024 •

edited

Loading

RequestError will be revised anyway, so now it's ok to react to them similarly. It would be nice to have a test here, btw =)

LGTM

loyd merged commit f61dbf7 into elfo-rs:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment