New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): implement logs truncation when line size limit exceedes #128

Merged

loyd merged 10 commits into elfo-rs:master from nerodono:feat/elfo-logger-line-truncation

Jun 14, 2024

Contributor

nerodono commented Jun 5, 2024

Adds max_line_size option to logger config. Truncation is performed in the following order:

payload
meta (timestamp, level, trace id)
fields (location, module)

nerodono added 3 commits

June 5, 2024 15:52


          feat(logger): implement logs truncation when line size limit exceedes

b75d674


          fix(logger): finish Drop comment and satisfy rustc visibility warning

e44804d


          chore(logger): place comment before derive

8148aff

loyd requested changes

View reviewed changes

examples/examples/usage/config.toml Outdated Show resolved Hide resolved

elfo-logger/src/config.rs Outdated Show resolved Hide resolved

elfo-logger/src/config.rs Outdated Show resolved Hide resolved

elfo-logger/src/theme.rs Outdated Show resolved Hide resolved

elfo-logger/src/formatters.rs Outdated Show resolved Hide resolved

elfo-logger/src/actor.rs Show resolved Hide resolved

elfo-logger/src/line_buffer.rs Show resolved Hide resolved

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

elfo-logger/src/line_buffer.rs Show resolved Hide resolved

elfo-logger/src/config.rs Outdated Show resolved Hide resolved


          perf(logger): use fast-path with static dispatch to use only one buff…

bd8d9cf

…er if line size limit is not exceeded

nerodono force-pushed the feat/elfo-logger-line-truncation branch from c468cd9 to bd8d9cf Compare

June 6, 2024 12:06

loyd reviewed

View reviewed changes

elfo-logger/Cargo.toml Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/config.rs Outdated Show resolved Hide resolved


          fix(logger): remove feature docsrs, use cfg(docsrs) instead, move…

1af39a8

… `bytesize` to workspace dependencies, fix doc-comments to be more precise

loyd reviewed

View reviewed changes

examples/examples/usage/config.toml Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/actor.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/actor.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/actor.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_transaction.rs Outdated Show resolved Hide resolved

nerodono added 2 commits

June 13, 2024 14:37


          refactor(logger): Make line buffering code cleaner


          chore(logger): move docs to the struct definition

ccb7672

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_transaction.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/actor.rs Show resolved Hide resolved

loyd reviewed

View reviewed changes

elfo-logger/src/line_buffer.rs Outdated Show resolved Hide resolved

nerodono added 3 commits

June 13, 2024 17:27


          refactor(logger): add " TRUNCATED" string to truncated logs and sim…

0d59222

…plify line buffer interface


          refactor(logger): cleaner names for write strategies (CurrentLine -…

c2495f0

…> `TruncatingWrite`, by the same logic as `DirectWrite`), make rollbacks in `Drop`, since it is more robust


          fix(logger): clear event by payload_id

941430e

loyd approved these changes

View reviewed changes

loyd merged commit 123df3c into elfo-rs:master

4 checks passed

loyd added a commit that referenced this pull request


          docs(CHANGELOG): note about #128

98d0339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment