Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve File Modes #107

Merged
merged 10 commits into from
Aug 20, 2023
Merged

Preserve File Modes #107

merged 10 commits into from
Aug 20, 2023

Commits on Aug 19, 2023

  1. Use RFC 5322 date in test script 

    As find -d cannot always parse the default output format of date.
    @veselink1
    veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    e2444ea View commit details
    Browse the repository at this point in the history

  2. [NFC] Add perm arg to create_file 

    This is a nop change to introduce a parameter which enables us to
control the permissions of the created file.

Since it defaults to the old behaviour, no functional changes are
intended (NFC).
    @peterwaller-arm @veselink1
    peterwaller-arm authored and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    eed08ce View commit details
    Browse the repository at this point in the history

  3. Rename FileEntry.{metadata => object_metadata} 

    Soon introducing file metadata as distinct from object metadata.

Object metadata: That which relates to the object as it appears in the
pack.

File metadata: That which relates to the path, such as file modes.
    @peterwaller-arm @veselink1
    peterwaller-arm authored and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    0608a6d View commit details
    Browse the repository at this point in the history

  4. [Format version 2] Add FileMetadata to FileHandle for modes 

    This adds a FileMetadata as a part of the FileHandle.

This does make me question if FileHandle is now appropriately named, but
logically, the file metadata is a part of the file state which should
be considered changed along with the other properties of the FileHandle,
so this seems like the correct place to put this information for now.

Co-authored-by: Vesko Karaganev <vesko.karaganev@gmail.com>
    @peterwaller-arm @veselink1
    peterwaller-arm and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    8c8d66a View commit details
    Browse the repository at this point in the history

  5. Wire up modes 

    Prior to this commit, modes did nothing since they were not populated.
After this commit, they are populated in the index, and that information
is used to specify modes on the created files.

Closes #13.

Co-authored-by: Vesko Karaganev <vesko.karaganev@gmail.com>
    @peterwaller-arm @veselink1
    peterwaller-arm and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    411260c View commit details
    Browse the repository at this point in the history

  6. Add test_extract_file_modes_preserved 

    Co-authored-by: Vesko Karaganev <vesko.karaganev@gmail.com>
    @peterwaller-arm @veselink1
    peterwaller-arm and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    8dea1b9 View commit details
    Browse the repository at this point in the history

  7. [NFCI] Use scope rather than drop for file lifetime 

    Addresses a review comment in #107.
    @peterwaller-arm @veselink1
    peterwaller-arm authored and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    c46fa95 View commit details
    Browse the repository at this point in the history

  8. Include file_metadata in snapshot identity hash 

    Co-authored-by: Vesko Karaganev <vesko.karaganev@gmail.com>
    @peterwaller-arm @veselink1
    peterwaller-arm and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    5d9809a View commit details
    Browse the repository at this point in the history

  9. Drop '-p' from nc -l args 

    It appears to be optional on an old Ubuntu installation, but in more
recent versions of nc, -p is rejected with -l.
    @peterwaller-arm @veselink1
    peterwaller-arm authored and veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    28e2b03 View commit details
    Browse the repository at this point in the history

  10. Add file mode (permissions) to list-files

    @veselink1
    veselink1 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    9015963 View commit details
    Browse the repository at this point in the history