Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowKodiChangeArtworksNonLibrary #71

Closed
wants to merge 1 commit into from

Conversation

antonsoroko
Copy link

@antonsoroko antonsoroko commented Jun 21, 2021

@elgatito
Copy link
Owner

@antonsoroko Why this is needed? It will not allow to change artwork for something that is not in the library.

@antonsoroko
Copy link
Author

@elgatito
it will if user will enable it.

but looks like that some skins uses some addons that fail when they see fake lib id.

elgatito/plugin.video.elementum#795 (comment)

@antonsoroko
Copy link
Author

antonsoroko commented Jun 21, 2021

log file example from user
elgatito/plugin.video.elementum#795 (comment)

2021-06-21 09:20:19.675 T:308     DEBUG <general>: script.module.metadatautils --> {'jsonrpc': '2.0', 'method': 'VideoLibrary.GetMovieDetails', 'params': {'movieid': 1000293660, 'properties': ['dateadded', 'file', 'lastplayed', 'plot', 'title', 'art', 'playcount', 'streamdetails', 'director', 'resume', 'runtime', 'plotoutline', 'sorttitle', 'cast', 'votes', 'showlink', 'top250', 'trailer', 'year', 'country', 'studio', 'set', 'genre', 'mpaa', 'setid', 'rating', 'tag', 'tagline', 'writer', 'originaltitle', 'imdbnumber', 'uniqueid']}, 'id': 1}
2021-06-21 09:20:19.675 T:308   WARNING <general>: Skin Helper Service --> Exception details: Type: KeyError Value: 'cast' Traceback: Traceback (most recent call last):
                                                     File "C:\Users\Marko\AppData\Roaming\Kodi\addons\script.skin.helper.service\resources\lib\plugin_content.py", line 67, in main
                                                       getattr(self, action)()
                                                     File "C:\Users\Marko\AppData\Roaming\Kodi\addons\script.skin.helper.service\resources\lib\plugin_content.py", line 266, in getcast
                                                       all_cast = self.mutils.kodidb.movie(db_id)["cast"]
                                                   KeyError: 'cast'                                                   
2021-06-21 09:20:19.675 T:308     ERROR <general>: Skin Helper Service --> Exception in resources.lib.plugin_content ! --> 'cast'
...
2021-06-21 09:20:25.237 T:8272    DEBUG <general>: script.module.metadatautils --> {'jsonrpc': '2.0', 'method': 'VideoLibrary.GetTvShowDetails', 'params': {'tvshowid': 1000001399, 'properties': ['dateadded', 'file', 'lastplayed', 'plot', 'title', 'art', 'playcount', 'sorttitle', 'mpaa', 'premiered', 'year', 'episode', 'watchedepisodes', 'votes', 'rating', 'studio', 'season', 'genre', 'cast', 'episodeguide', 'tag', 'originaltitle', 'imdbnumber']}, 'id': 1}
2021-06-21 09:20:25.238 T:8272  WARNING <general>: Skin Helper Service --> Exception details: Type: KeyError Value: 'season' Traceback: Traceback (most recent call last):
                                                     File "C:\Users\Marko\AppData\Roaming\Kodi\addons\script.skin.helper.service\resources\lib\plugin_content.py", line 67, in main
                                                       getattr(self, action)()
                                                     File "C:\Users\Marko\AppData\Roaming\Kodi\addons\script.skin.helper.service\resources\lib\plugin_content.py", line 272, in getcast
                                                       all_cast = self.mutils.kodidb.tvshow(db_id)["cast"]
                                                     File "C:\Users\Marko\AppData\Roaming\Kodi\addons\script.module.metadatautils\lib\helpers\kodidb.py", line 57, in tvshow
                                                       return self.tvshow_watchedcounts(tvshow)
                                                     File "C:\Users\Marko\AppData\Roaming\Kodi\addons\script.module.metadatautils\lib\helpers\kodidb.py", line 742, in tvshow_watchedcounts
                                                       tvshow["extraproperties"] = {"totalseasons": str(tvshow["season"]),
                                                   KeyError: 'season'
2021-06-21 09:20:25.238 T:8272    ERROR <general>: Skin Helper Service --> Exception in resources.lib.plugin_content ! --> 'season'

@antonsoroko
Copy link
Author

close in favor of #74

@antonsoroko antonsoroko deleted the manage-artworks-fix branch February 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants