Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit into group ironman bank does not work #16

Closed
elgbar opened this issue Mar 2, 2024 · 2 comments
Closed

Deposit into group ironman bank does not work #16

elgbar opened this issue Mar 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@elgbar
Copy link
Owner

elgbar commented Mar 2, 2024

Describe the bug

Group ironman bank storage; upon depositing items to the group storage (with this plugin enabled) the items actually go to the storage. However, the item I just deposited "appears" on my inventory still, yet having the option to still "deposit" them, even though they don't actually exist in my inventory anymore.

To Reproduce
Steps to reproduce the behaviour:

  1. Open Group Storage on a Group Ironman
  2. Deposit item(s) into the bank
  3. The item will reappear in the bank container.

Expected behaviour

The item should disappear when being deposited into the group ironman bank.

Screenshots

gim-deposit-bug.webm

Additional context

Originally reported in #14 (comment)

@elgbar elgbar added the bug Something isn't working label Mar 2, 2024
@elgbar elgbar self-assigned this Mar 2, 2024
elgbar added a commit that referenced this issue Mar 2, 2024
When the group storage is open a different inventory id used.
This fixes validating items in the wrong inventory container.
@elgbar
Copy link
Owner Author

elgbar commented Mar 2, 2024

Fixed in v1.2.1

@elgbar elgbar closed this as completed Mar 2, 2024
@elgbar elgbar pinned this issue Mar 2, 2024
@elgbar
Copy link
Owner Author

elgbar commented Mar 2, 2024

To add some context to this issue: Normally the plugin validate the state of the inventory by looking at the inventory container found with InventoryID.INVENTORY, but when the group storage is open another inventory is used called InventoryID.GROUP_STORAGE_INV.

The issue is that the normal inventory does not get updated when in the group storage, thus it will reset items to the incorrect state. This is now resolved by selecting the correct inventory when the group storage is open.

A slight complication is that if there are no items in the inventory (e.g., after depositing all items) the InventoryID.GROUP_STORAGE_INV will no longer exist, i.e., be reported as null. This is accounted for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant