-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to prompt_toolkit 2.0.x - take over jonathanslenders's works #152
Conversation
Oh, it has problems on python27. |
iPython on py27 uses prompt-toolkit<2.0.0, and on py36 uses prompt-toolkit>2.0.0, so I put changes that environment on python2 uses prompt-toolkit<2.0 and environment on python3 uses prompt-toolkit>2.0.
Since pytest-cov ver 2.6, it needs pytest v3.6 over, so pytest-cov version should be limited under 2.6.0.
Since pytest-cov v2.6, it needs pytest v3.6 over. Latest pytest ver is 4.3.1. I think it is better to update pytest minimum version to over 3.6. |
How do you think about changing prompt-toolkit version according to iPython? iPython have 3 version combination patterns as wrote below:
I think most people suffer from incompatible prompt-toolkit version between http-prompt and iPython, therefore I think changing PT version according to iPython is good idea personally. |
Why not use try: except: blocks and support both. |
I merged #137, this is no more needed (thanks @boarnasia for the patch). |
I patched jonathanslenders's works into the latest source.
I don't know why this update stop for a long time, and creating new pull request is good manner or not, but I think http-prompt works with prompt_tookit 2.0.x is things I need.
Almost changes is the same as jonathanslenders's. I added only information message for KeyboardInterrupt exception on http_prompt/cli.py:169.