Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow passing custom config to Config object #3

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

eliashaeussler
Copy link
Owner

This PR introduces a new Config::withConfig() method. It can be used to pass an object of type \PhpCsFixer\Config, leading to an overwritten rule set, risky setting and Finder instance. This is especially useful in combination with other packages that provide a ready-to-use PHP-CS-Fixer config object (e.g. typo3/coding-standards).

@eliashaeussler eliashaeussler added the enhancement New feature or request label Feb 19, 2023
@eliashaeussler eliashaeussler self-assigned this Feb 19, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 19, 2023

Code Climate has analyzed commit d9cf92e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d9cf92e) compared to base (6fd4473).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##                main        #3   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        17        18    +1     
===========================================
  Files              5         5           
  Lines             62        67    +5     
===========================================
+ Hits              62        67    +5     
Impacted Files Coverage Δ
src/Config.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eliashaeussler eliashaeussler merged commit 5dbc3cd into main Feb 19, 2023
@eliashaeussler eliashaeussler deleted the feature/custom-config branch February 19, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant