made minor changes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishoreVB70
commented
Oct 5, 2022
KishoreVB70
commented
- Added the validInput modifier to check for the input of the reserveName function and the set avicon function
- Added the function to change the price of the CName
- Added only owner modifier and valid value modifier for the sell and change price function
✅ Deploy Preview for celonameservice ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
eliashezron
reviewed
Oct 5, 2022
There was a problem hiding this comment.
validValue and ValidInput modifiers are not necessary In the smart contract as they are implemented in the frontend of the application. its important the the smart contract be kept simple and precise to minimise gas expenses.
as per the project, their isnt a specific need for the onlyOwner modifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.