Conditional locale support #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
eliaskosunen
force-pushed
the
feature-locale-override
branch
from
46c8f2f
to
0f95381
Compare
|
To better align with #70, I also changed the macro name here to After rebasing on top of latest master, looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the remaining issues in #69.
It was not as difficult as I imagined, but it took a much deeper understanding of the codebase.
Note that I dropped the locale override macros, as I later realized they were ill-conceived.
I have tried to be as minimally invasive as possible, mainly cutting out call-sites and letting the optimizer take care of the rest. This may not be the best solution, but it required the fewest changes. As far as I can tell, there are no remnants of
std::locale.My final size reduction is 135K!