Conditional type support #70
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
|
Apologies for the churn. Modern C++ has gotten so much easier, I often forget how to do it the old way (and which old way goes with which standard). |
Add compile-time options `SCN_TYPE_*` for all types, and `SCN_USE_FROM_CHARS` and `SCN_USE_CSTD`, primarily for compiled size reductions, and in case a platform doesn't support some of them.
eliaskosunen
force-pushed
the
feature-conditional-float
branch
2 times, most recently
from
11d5be1
to
7d1abbb
Compare
Invert the condition: SCN_TYPE_FOO -> SCN_DISABLE_TYPE_FOO Also, define defaults in config.h (all enabled), and don't add definitions in CMake if type not disabled. As a drive-by fix, also improve some error messages in reader_float
eliaskosunen
force-pushed
the
feature-conditional-float
branch
from
7d1abbb
to
9846437
Compare
|
I inverted the conditions, so that the macros are Other that than, looks good. Rebased, signed, and merged. Thank you! |
|
Hey I'm just happy to have the options! Thanks for getting this cleaned up and merged. |
Resolves non-locale problems listed in #69.
There are probably a few sections which do not require conditional compilation, as eliminating calls further up the chain would suffice. But I have not determined where best to do so, and this is easy to modify later.After becoming more acquainted with the code, I found the correct location. I also decided that all types should fall into this setup, not just floating-point.
The one thing I'm not 100% sure of is the
static_assertplacement. I think the two of them cover everything, but it's a little hard to tell.The size reduction for my project is 23K (no fallbacks; schar, uchar, long, ulong, bool, float, buffer, and custom enabled).